Re: [PATCH 02/11] mmu: add physical address parameter to arch_remap_range

[Sascha Hauer <sha@pengutronix.de>]

On Tue, May 23, 2023 at 09:21:03AM +0200, Ahmad Fatoum wrote:
> On 23.05.23 09:17, Sascha Hauer wrote:
> > On Mon, May 22, 2023 at 07:28:26AM +0200, Ahmad Fatoum wrote:
> >> ARM32 has map_io_sections for non-1:1 remapping, but it's limited to 1M
> >> sections.  arch_remap_range has newly gained support for 4K granularity
> >> remapping, but supports only changing attributes and no non-1:1
> >> remapping yet. In preparation for adding this missing feature, adjust
> >> the prototype.
> >>
> >> No functional change.
> >>
> >> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> >> ---
> >>  arch/arm/cpu/mmu_32.c          | 25 ++++++++++++++-----------
> >>  arch/arm/cpu/mmu_64.c          |  8 +++++---
> >>  arch/arm/include/asm/mmu.h     |  2 +-
> >>  arch/powerpc/cpu-85xx/mmu.c    |  7 +++++--
> >>  arch/powerpc/include/asm/mmu.h |  2 +-
> >>  include/mmu.h                  |  9 ++++++---
> >>  6 files changed, 32 insertions(+), 21 deletions(-)
> >>
> >> diff --git a/arch/arm/cpu/mmu_32.c b/arch/arm/cpu/mmu_32.c
> >> index e4607d99fd2a..68336fc68be0 100644
> >> --- a/arch/arm/cpu/mmu_32.c
> >> +++ b/arch/arm/cpu/mmu_32.c
> >> @@ -253,20 +253,23 @@ static uint32_t get_pmd_flags(int map_type)
> >>  	return pte_flags_to_pmd(get_pte_flags(map_type));
> >>  }
> >>  
> >> -int arch_remap_range(void *start, size_t size, unsigned map_type)
> >> +int arch_remap_range(void *_virt_addr, phys_addr_t phys_addr, size_t size, unsigned map_type)
> > 
> > The prototype is changed here, but not its caller in the same file.
> > Fixed that up.
> 
> I don't have a caller in the same file. Everything should have been switched
> to remap_range by now, except for remap_range's implementation itself.
> 
> If you added another arch_remap_range callsite in your MMU patches, please
> change it on the previous commit.

Yes, right. I changed that.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |