From: Sascha Hauer <sha@pengutronix.de>
To: Johannes Zink <j.zink@pengutronix.de>
Cc: barebox@lists.infradead.org, ahmad@a3f.at, afa@pengutronix.de,
kernel@pengutronix.de, patchwork-jzi@pengutronix.de
Subject: Re: [PATCH 0/2] imx-usb-loader: fixes in displaying version number
Date: Tue, 30 May 2023 08:27:29 +0200 [thread overview]
Message-ID: <20230530062729.GW17518@pengutronix.de> (raw)
In-Reply-To: <20230526165947.1079052-1-j.zink@pengutronix.de>
On Fri, May 26, 2023 at 06:59:46PM +0200, Johannes Zink wrote:
> As Ahmad pointed out in [1], compilation failed if the prepare make
> target was not called before compiling the imx-usb-loader, which caused
> the generated file not to exist when building for the sandbox target and
> broke the build.
>
> Instead of continuing to pursue the approach discussed in [2], a rather
> straight-foreward approach of adding utsrelease.h as a dependency to
> scripts has been chosen, as now the already-existing infrastucture can
> be used instead of duplicating code in the Makefile.
>
> Also, the version number was only set for the Host Tool, but not in the
> target tool, which the second patch of this series fixes.
>
> As the original patch was accidentaly sent out as a fixup, and as this
> series chooses a slightly different approach, I decided to open a new
> series.
>
> Best regards
> Johannes
>
> [1] https://lore.barebox.org/barebox/20230525181320.2277320-1-ahmad@a3f.at/
> [2] https://lore.barebox.org/barebox/20230526070847.52738-1-j.zink@pengutronix.de/
>
> Johannes Zink (2):
> imx-usb-loader: fix compilation if prepare make target was not called
> before
> imx-usb-loader: also add version information on target tool
>
> Makefile | 2 +-
> scripts/imx/Makefile | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2023-05-30 6:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 16:59 Johannes Zink
2023-05-26 16:59 ` [PATCH 1/2] imx-usb-loader: fix compilation if prepare make target was not called before Johannes Zink
2023-05-26 18:42 ` Ahmad Fatoum
2023-05-26 16:59 ` [PATCH 2/2] imx-usb-loader: also add version information on target tool Johannes Zink
2023-05-30 6:27 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230530062729.GW17518@pengutronix.de \
--to=sha@pengutronix.de \
--cc=afa@pengutronix.de \
--cc=ahmad@a3f.at \
--cc=barebox@lists.infradead.org \
--cc=j.zink@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=patchwork-jzi@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox