mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] regulator: core: add debug print for regulator_resolve_supply
@ 2023-05-31  6:29 Ahmad Fatoum
  2023-06-01  6:51 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2023-05-31  6:29 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

Starting with commit 324bd9bbe7e8 ("regulator: recursively enable/disable
regulator dependency tree"), regulator operations may affect more than
just the one regulator being enabled. Place a debug print, so it's
easier to follow the dependency chain.

Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
 drivers/regulator/core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 42774a561ce5..f914641c8777 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -141,6 +141,8 @@ static int regulator_resolve_supply(struct regulator_dev *rdev)
 	if (!supply_name)
 		return 0;
 
+	dev_dbg(rdev->dev, "resolving %s\n", supply_name);
+
 	supply = regulator_get(rdev->dev, supply_name);
 	if (IS_ERR(supply)) {
 		if (deep_probe_is_supported())
-- 
2.38.5




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] regulator: core: add debug print for regulator_resolve_supply
  2023-05-31  6:29 [PATCH] regulator: core: add debug print for regulator_resolve_supply Ahmad Fatoum
@ 2023-06-01  6:51 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2023-06-01  6:51 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox

On Wed, May 31, 2023 at 08:29:23AM +0200, Ahmad Fatoum wrote:
> Starting with commit 324bd9bbe7e8 ("regulator: recursively enable/disable
> regulator dependency tree"), regulator operations may affect more than
> just the one regulator being enabled. Place a debug print, so it's
> easier to follow the dependency chain.
> 
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
> ---
>  drivers/regulator/core.c | 2 ++
>  1 file changed, 2 insertions(+)

Applied, thanks

Sascha

> 
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index 42774a561ce5..f914641c8777 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -141,6 +141,8 @@ static int regulator_resolve_supply(struct regulator_dev *rdev)
>  	if (!supply_name)
>  		return 0;
>  
> +	dev_dbg(rdev->dev, "resolving %s\n", supply_name);
> +
>  	supply = regulator_get(rdev->dev, supply_name);
>  	if (IS_ERR(supply)) {
>  		if (deep_probe_is_supported())
> -- 
> 2.38.5
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-06-01  6:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-31  6:29 [PATCH] regulator: core: add debug print for regulator_resolve_supply Ahmad Fatoum
2023-06-01  6:51 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox