Re: [PATCH 1/2] commands: stat: print symlink destination when called without -L

[Sascha Hauer <sha@pengutronix.de>]

On Wed, May 31, 2023 at 03:23:30PM +0200, Ahmad Fatoum wrote:
> This aligns behavior with usual implementations of stat.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  fs/fs.c | 17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/fs/fs.c b/fs/fs.c
> index 368458cc54f8..311571ba3088 100644
> --- a/fs/fs.c
> +++ b/fs/fs.c
> @@ -130,8 +130,6 @@ void stat_print(const char *filename, const struct stat *st)
>  		case S_IFREG:    type = "regular file"; break;
>  	}
>  
> -	printf("  File: %s\n", filename);
> -
>  	if (st->st_mode & S_IFCHR) {
>  		char *path;
>  
> @@ -147,6 +145,21 @@ void stat_print(const char *filename, const struct stat *st)
>  		}
>  	}
>  
> +	printf("  File: %s", filename);
> +
> +	if (S_ISLNK(st->st_mode)) {
> +		char realname[PATH_MAX] = {};
> +		int ret;
> +
> +		ret = readlink(filename, realname, PATH_MAX - 1);
> +		if (ret)
> +			printf(" -> <readlink error %pe>", ERR_PTR(ret));
> +		else
> +			printf(" -> %s", realname);
> +	}
> +
> +	printf("\n");
> +
>  	printf("  Size: %-20llu", st->st_size);
>  	if (bdev)
>  		printf("Blocks: %llu\tIO Block: %u\t",
> -- 
> 2.39.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |