From: Marco Felsch <m.felsch@pengutronix.de>
To: Sascha Hauer <sha@pengutronix.de>
Cc: Johannes Zink <j.zink@pengutronix.de>,
barebox@lists.infradead.org, patchwork-jzi@pengutronix.de,
Juergen Borleis <j.borleis@pengutronix.de>
Subject: Re: [PATCH] ARM: i.MX8MP: add Koenig+Bauer Alphajet board
Date: Thu, 1 Jun 2023 10:40:02 +0200 [thread overview]
Message-ID: <20230601084002.jvs6layjwob2me3r@pengutronix.de> (raw)
In-Reply-To: <20230601082825.GL18491@pengutronix.de>
Hi Sascha,
On 23-06-01, Sascha Hauer wrote:
> On Thu, Jun 01, 2023 at 09:40:29AM +0200, Johannes Zink wrote:
...
> > +#define EQOS_PWR_PIN IMX_GPIO_NR(1, 5) /* ENET_PWREN# */
> > +static void setup_ethernet_phy(void)
> > +{
> > + u32 val;
> > +
> > + of_device_ensure_probed_by_alias("gpio0");
> > +
> > + if (gpio_direction_output(EQOS_PWR_PIN, 0))
> > + {
> > + pr_err("eqos phy power: failed to request pin\n");
> > + return;
> > + }
>
> Should this be a fixed regulator in dt?
Sorry for stepping in here. I think the problem was that neither the
kernel nor the barebox EQOS driver support the regulator feature. But
you're right this should be the correct solution.
Regards,
Marco
next prev parent reply other threads:[~2023-06-01 8:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 7:40 Johannes Zink
2023-06-01 7:53 ` Marco Felsch
2023-06-01 8:28 ` Sascha Hauer
2023-06-01 8:40 ` Marco Felsch [this message]
2023-06-01 8:41 ` Johannes Zink
2023-06-01 8:50 ` Ahmad Fatoum
2023-06-01 8:49 ` Ahmad Fatoum
2023-06-01 9:08 ` Johannes Zink
2023-06-01 9:14 ` Ahmad Fatoum
2023-06-01 9:20 ` Johannes Zink
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230601084002.jvs6layjwob2me3r@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=j.borleis@pengutronix.de \
--cc=j.zink@pengutronix.de \
--cc=patchwork-jzi@pengutronix.de \
--cc=sha@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox