From: Sascha Hauer <s.hauer@pengutronix.de>
To: Denis Orlov <denorl2009@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] net: r8169: fix builds on archs without system.h header
Date: Mon, 5 Jun 2023 15:48:53 +0200 [thread overview]
Message-ID: <20230605134853.GQ18491@pengutronix.de> (raw)
In-Reply-To: <20230604210609.17765-1-denorl2009@gmail.com>
On Mon, Jun 05, 2023 at 12:05:55AM +0300, Denis Orlov wrote:
> Some architectures do lack <asm/system.h> header, which breaks building
> RTL8169 for them. However, it doesn't even seem to be needed there. From
> a quick glance at archs that do have one such header, its contents are
> quite platform-specific. Getting rid of this include fixes building the
> driver, so do just that.
>
> Signed-off-by: Denis Orlov <denorl2009@gmail.com>
> ---
> drivers/net/r8169_main.c | 1 -
> 1 file changed, 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/net/r8169_main.c b/drivers/net/r8169_main.c
> index 5b448fa029..2225c26190 100644
> --- a/drivers/net/r8169_main.c
> +++ b/drivers/net/r8169_main.c
> @@ -17,7 +17,6 @@
> #include <linux/pci.h>
> #include <linux/sizes.h>
> #include <asm/unaligned.h>
> -#include <asm/system.h>
>
> #include "r8169.h"
> #include "r8169_firmware.h"
> --
> 2.41.0
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2023-06-05 13:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-04 21:05 Denis Orlov
2023-06-05 13:48 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230605134853.GQ18491@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=denorl2009@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox