[PATCH] net: r8169: fix builds on archs without system.h header

[PATCH] net: r8169: fix builds on archs without system.h header

[Denis Orlov]

Some architectures do lack <asm/system.h> header, which breaks building
RTL8169 for them. However, it doesn't even seem to be needed there. From
a quick glance at archs that do have one such header, its contents are
quite platform-specific. Getting rid of this include fixes building the
driver, so do just that.

Signed-off-by: Denis Orlov <denorl2009@gmail.com>
---
 drivers/net/r8169_main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/r8169_main.c b/drivers/net/r8169_main.c
index 5b448fa029..2225c26190 100644
--- a/drivers/net/r8169_main.c
+++ b/drivers/net/r8169_main.c
@@ -17,7 +17,6 @@
 #include <linux/pci.h>
 #include <linux/sizes.h>
 #include <asm/unaligned.h>
-#include <asm/system.h>
 
 #include "r8169.h"
 #include "r8169_firmware.h"
-- 
2.41.0

Re: [PATCH] net: r8169: fix builds on archs without system.h header

[Sascha Hauer]

On Mon, Jun 05, 2023 at 12:05:55AM +0300, Denis Orlov wrote:
> Some architectures do lack <asm/system.h> header, which breaks building
> RTL8169 for them. However, it doesn't even seem to be needed there. From
> a quick glance at archs that do have one such header, its contents are
> quite platform-specific. Getting rid of this include fixes building the
> driver, so do just that.
> 
> Signed-off-by: Denis Orlov <denorl2009@gmail.com>
> ---
>  drivers/net/r8169_main.c | 1 -
>  1 file changed, 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/net/r8169_main.c b/drivers/net/r8169_main.c
> index 5b448fa029..2225c26190 100644
> --- a/drivers/net/r8169_main.c
> +++ b/drivers/net/r8169_main.c
> @@ -17,7 +17,6 @@
>  #include <linux/pci.h>
>  #include <linux/sizes.h>
>  #include <asm/unaligned.h>
> -#include <asm/system.h>
>  
>  #include "r8169.h"
>  #include "r8169_firmware.h"
> -- 
> 2.41.0
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |