From: Sascha Hauer <sha@pengutronix.de>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/3] i2c: add <pbl/eeprom.h> for PBL use
Date: Tue, 6 Jun 2023 13:21:48 +0200 [thread overview]
Message-ID: <20230606112148.GE18491@pengutronix.de> (raw)
In-Reply-To: <20230606-phytec-som-imx8mm-v1-1-b9c2bf70b766@pengutronix.de>
On Tue, Jun 06, 2023 at 12:50:02PM +0200, Marc Kleine-Budde wrote:
> Add a small helper to read a single page of EEPROM data.
>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
> include/pbl/eeprom.h | 34 ++++++++++++++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/include/pbl/eeprom.h b/include/pbl/eeprom.h
> new file mode 100644
> index 000000000000..b713cf154c99
> --- /dev/null
> +++ b/include/pbl/eeprom.h
> @@ -0,0 +1,34 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef __PBL_EEPROM_H_
> +#define __PBL_EEPROM_H_
> +
> +#include <common.h>
> +#include <pbl/i2c.h>
> +
> +static inline void eeprom_read(struct pbl_i2c *i2c, u16 client_addr, u32 addr, void *buf, u16 count)
> +{
> + u8 msgbuf[2];
> + struct i2c_msg msg[] = {
> + {
> + .addr = client_addr,
> + .buf = msgbuf,
> + }, {
> + .addr = client_addr,
> + .flags = I2C_M_RD,
> + .buf = buf,
> + .len = count,
> + },
> + };
> + int ret, i = 0;
> +
> + if (addr & I2C_ADDR_16_BIT)
> + msgbuf[i++] = addr >> 8;
> + msgbuf[i++] = addr;
> + msg->len = i;
I wasn't aware that an array can be accessed as a pointer. I would
prefer msg[0].len = i here.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2023-06-06 11:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 10:50 [PATCH 0/3] ARM: i.MX8MM: add Phytec i.MX8 SoM support Marc Kleine-Budde
2023-06-06 10:50 ` [PATCH 1/3] i2c: add <pbl/eeprom.h> for PBL use Marc Kleine-Budde
2023-06-06 11:21 ` Sascha Hauer [this message]
2023-06-06 11:33 ` Marc Kleine-Budde
2023-06-06 10:50 ` [PATCH 2/3] common: board: phytec: import SoM detection for imx8m based SoM from u-boot Marc Kleine-Budde
2023-06-06 12:51 ` Ahmad Fatoum
2023-06-06 14:32 ` Marc Kleine-Budde
2023-06-06 10:50 ` [PATCH 3/3] ARM: i.MX8MM: add Phytec i.MX8 SoM support Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230606112148.GE18491@pengutronix.de \
--to=sha@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox