[PATCH] net: cpsw: increase a delay before reading the ALIVE register

[PATCH] net: cpsw: increase a delay before reading the ALIVE register

[yegorslists]

From: Yegor Yefremov <yegorslists@googlemail.com>

At leasr am335x, the delay is not enough to reliably detect all PHYs.
Hence, increase the timeout.

Tested with the followings PHYs:

- MotorComm YT8511
- Atheros AT8035
- CPlus IP101A

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 drivers/net/cpsw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/cpsw.c b/drivers/net/cpsw.c
index 0449240f98..fdf6ff1e8e 100644
--- a/drivers/net/cpsw.c
+++ b/drivers/net/cpsw.c
@@ -620,7 +620,7 @@ static int cpsw_mdio_probe(struct device *dev)
 	 * silicon.  Since the effect of (b) was found to be largely
 	 * negligible, we keep things simple here.
 	 */
-	udelay(1000);
+	udelay(2000);
 
 	start = get_time_ns();
 	while (1) {
-- 
2.34.1

Re: [PATCH] net: cpsw: increase a delay before reading the ALIVE register

[Sascha Hauer]

On Fri, Jun 09, 2023 at 11:02:17AM +0200, yegorslists@googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> At leasr am335x, the delay is not enough to reliably detect all PHYs.
> Hence, increase the timeout.
> 
> Tested with the followings PHYs:
> 
> - MotorComm YT8511
> - Atheros AT8035
> - CPlus IP101A
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
>  drivers/net/cpsw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/net/cpsw.c b/drivers/net/cpsw.c
> index 0449240f98..fdf6ff1e8e 100644
> --- a/drivers/net/cpsw.c
> +++ b/drivers/net/cpsw.c
> @@ -620,7 +620,7 @@ static int cpsw_mdio_probe(struct device *dev)
>  	 * silicon.  Since the effect of (b) was found to be largely
>  	 * negligible, we keep things simple here.
>  	 */
> -	udelay(1000);
> +	udelay(2000);
>  
>  	start = get_time_ns();
>  	while (1) {
> -- 
> 2.34.1
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |