From: Sascha Hauer <sha@pengutronix.de>
To: yegorslists@googlemail.com
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] net: cpsw: increase a delay before reading the ALIVE register
Date: Mon, 12 Jun 2023 08:28:22 +0200 [thread overview]
Message-ID: <20230612062822.GT18491@pengutronix.de> (raw)
In-Reply-To: <20230609090217.2492987-1-yegorslists@googlemail.com>
On Fri, Jun 09, 2023 at 11:02:17AM +0200, yegorslists@googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
>
> At leasr am335x, the delay is not enough to reliably detect all PHYs.
> Hence, increase the timeout.
>
> Tested with the followings PHYs:
>
> - MotorComm YT8511
> - Atheros AT8035
> - CPlus IP101A
>
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
> drivers/net/cpsw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/net/cpsw.c b/drivers/net/cpsw.c
> index 0449240f98..fdf6ff1e8e 100644
> --- a/drivers/net/cpsw.c
> +++ b/drivers/net/cpsw.c
> @@ -620,7 +620,7 @@ static int cpsw_mdio_probe(struct device *dev)
> * silicon. Since the effect of (b) was found to be largely
> * negligible, we keep things simple here.
> */
> - udelay(1000);
> + udelay(2000);
>
> start = get_time_ns();
> while (1) {
> --
> 2.34.1
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2023-06-12 6:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 9:02 yegorslists
2023-06-12 6:28 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230612062822.GT18491@pengutronix.de \
--to=sha@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox