From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH master 5/6] memory_display: don't skip va_end in error case
Date: Mon, 12 Jun 2023 14:53:30 +0200 [thread overview]
Message-ID: <20230612125331.1085059-5-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20230612125331.1085059-1-a.fatoum@pengutronix.de>
There's a va_start at the start of __pr_memory_display, but va_end was
only called in the successful case. Fix this.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
common/memory_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/memory_display.c b/common/memory_display.c
index 77868be26ace..c0ca469703d3 100644
--- a/common/memory_display.c
+++ b/common/memory_display.c
@@ -123,9 +123,9 @@ int __pr_memory_display(int level, const void *addr, loff_t offs, unsigned nbyte
} while (nbytes > 0);
- va_end(args);
ret = 0;
out:
+ va_end(args);
return ret;
}
--
2.39.2
next prev parent reply other threads:[~2023-06-12 12:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 12:53 [PATCH master 1/6] net: smc1111: add missing drive's of_device_id array sentinel Ahmad Fatoum
2023-06-12 12:53 ` [PATCH master 2/6] scripts: remove openssl dependency in multi_v7_defconfig Ahmad Fatoum
2023-06-12 12:53 ` [PATCH master 3/6] clocksource: armv7m_systick: fix MMIO address Ahmad Fatoum
2023-06-12 12:53 ` [PATCH master 4/6] of: select OF_OVERLAY where appropriate Ahmad Fatoum
2023-06-12 12:53 ` Ahmad Fatoum [this message]
2023-06-12 12:53 ` [PATCH master 6/6] regmap-mmio: fix use-after-free Ahmad Fatoum
2023-06-13 7:11 ` Sascha Hauer
2023-06-13 7:17 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230612125331.1085059-5-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox