From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 17/19] watchdog: imx28: use correct constant for computing timeout_max
Date: Mon, 12 Jun 2023 15:02:38 +0200 [thread overview]
Message-ID: <20230612130239.1087599-18-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20230612130239.1087599-1-a.fatoum@pengutronix.de>
timeout_max is a 32-bit variable, so storing ULONG_MAX / WDOG_TICK_RATE
into it causes a wrap around on 64-bit systems. As the SoC is a 32-bit
one, it's likely the original intention was for it to be U32_MAX
instead.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
drivers/watchdog/im28wd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/im28wd.c b/drivers/watchdog/im28wd.c
index 7df2e2d99506..b52e5851750b 100644
--- a/drivers/watchdog/im28wd.c
+++ b/drivers/watchdog/im28wd.c
@@ -187,7 +187,7 @@ static int imx28_wd_probe(struct device *dev)
return PTR_ERR(iores);
priv->regs = IOMEM(iores->start);
priv->wd.set_timeout = imx28_watchdog_set_timeout;
- priv->wd.timeout_max = ULONG_MAX / WDOG_TICK_RATE;
+ priv->wd.timeout_max = U32_MAX / WDOG_TICK_RATE;
priv->wd.hwdev = dev;
if (!(readl(priv->regs + MXS_RTC_STAT) & MXS_RTC_STAT_WD_PRESENT)) {
--
2.39.2
next prev parent reply other threads:[~2023-06-12 13:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 13:02 [PATCH 00/19] misc fixes building sandbox 64-bit allyesconfig Ahmad Fatoum
2023-06-12 13:02 ` [PATCH 01/19] clk: always define clk_prepare_enable/disable Ahmad Fatoum
2023-06-12 13:02 ` [PATCH 02/19] clk: define clk_get_parent stub Ahmad Fatoum
2023-06-12 13:02 ` [PATCH 03/19] pci: disable building CONFIG_PCI when CONFIG_COMPILE_TEST Ahmad Fatoum
2023-06-12 13:02 ` [PATCH 04/19] mci: tegra: fix base address constant to be hexadecimal Ahmad Fatoum
2023-06-12 13:02 ` [PATCH 05/19] ata: ide-sff: fix warnings when compiling as 64-bit Ahmad Fatoum
2023-06-12 13:02 ` [PATCH 06/19] video: bochs: remove dependency on PCI header in common part Ahmad Fatoum
2023-06-12 13:02 ` [PATCH 07/19] commands: ubsan: hide pointer provenance used to trigger UB Ahmad Fatoum
2023-06-12 13:02 ` [PATCH 08/19] test: self: printf: silence clang warnings Ahmad Fatoum
2023-06-12 13:02 ` [PATCH 09/19] crypto: caam - fix pointer to u32 casts Ahmad Fatoum
2023-06-12 13:02 ` [PATCH 10/19] crypto: imx-scc: fix u32 to pointer casts Ahmad Fatoum
2023-06-12 13:02 ` [PATCH 11/19] mci: sdhci: dove: fix pointer to u32 casts Ahmad Fatoum
2023-06-12 13:02 ` [PATCH 12/19] lib: make_directory: return -ENOMEM on allocation failure Ahmad Fatoum
2023-06-12 13:02 ` [PATCH 13/19] include <linux/idr.h>: handle OOM gracefully inside idr_alloc_one Ahmad Fatoum
2023-06-12 13:02 ` [PATCH 14/19] mci: tegra: use correct types for mmio and DMA address Ahmad Fatoum
2023-06-12 13:02 ` [PATCH 15/19] mtd: spi-nor: cadence: fix types Ahmad Fatoum
2023-06-12 13:02 ` [PATCH 16/19] video: simplefb-fixup: warn on framebuffers >= 4G Ahmad Fatoum
2023-06-12 13:02 ` Ahmad Fatoum [this message]
2023-06-12 13:02 ` [PATCH 18/19] firmware: mark firmware sections as having non-executable stack Ahmad Fatoum
2023-06-12 13:02 ` [PATCH 19/19] phy: stm32: usb: depend on COMMON_CLK Ahmad Fatoum
2023-06-13 7:49 ` [PATCH 00/19] misc fixes building sandbox 64-bit allyesconfig Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230612130239.1087599-18-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox