Re: [PATCH 5/5] dmesg: udpate help

[Marco Felsch <m.felsch@pengutronix.de>]

Hi Sascha,

On 23-06-12, Sascha Hauer wrote:
> Now that there are two options which take a loglevel as argument
> describe the available loglevels in the command description and
> not in the argument description.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  commands/dmesg.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/commands/dmesg.c b/commands/dmesg.c
> index 953bdb2068..ae85d98c1a 100644
> --- a/commands/dmesg.c
> +++ b/commands/dmesg.c
> @@ -154,12 +154,18 @@ static int do_dmesg(int argc, char *argv[])
>  	return 0;
>  }
>  
> +

Not required newline, with that fixed:

Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>

>  BAREBOX_CMD_HELP_START(dmesg)
> +BAREBOX_CMD_HELP_TEXT("print or control the barebox message buffer")
> +BAREBOX_CMD_HELP_TEXT("Loglevels can be specified as number (0=emerg, 7=vdebug)")
> +BAREBOX_CMD_HELP_TEXT("Known debug loglevels are: emerg, alert, crit, err, warn, notice, info, debug,")
> +BAREBOX_CMD_HELP_TEXT("vdebug")
> +BAREBOX_CMD_HELP_TEXT("")
>  BAREBOX_CMD_HELP_TEXT("Options:")
>  BAREBOX_CMD_HELP_OPT ("-c",		"Delete messages after printing them")
>  BAREBOX_CMD_HELP_OPT ("-d",		"Show a time delta to the last message")
>  BAREBOX_CMD_HELP_OPT ("-e <msg>",	"Emit a log message")
> -BAREBOX_CMD_HELP_OPT ("-l <vdebug|debug|info|notice|warn|err|crit|alert|emerg>", "Restrict output to the given (comma-separated) list of levels")
> +BAREBOX_CMD_HELP_OPT ("-l <loglevel>", "Restrict output to the given (comma-separated) list of levels")
>  BAREBOX_CMD_HELP_OPT ("-n <loglevel>", "Set level at which printing of messages is done to the console")
>  BAREBOX_CMD_HELP_OPT ("-r",		"Print timestamp and log-level prefixes.")
>  BAREBOX_CMD_HELP_OPT ("-t",		"Show timestamp informations")
> -- 
> 2.39.2
> 
> 
>