From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 13 Jun 2023 09:12:31 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q8yCe-004rfK-CU for lore@lore.pengutronix.de; Tue, 13 Jun 2023 09:12:31 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q8yCc-0006xt-4W for lore@pengutronix.de; Tue, 13 Jun 2023 09:12:30 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:From:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BaQ1Au+q3k8PEEucOqp7fMgc1HzsGaHzXmNgApEgZNU=; b=ZmhQdoc6ek+pKxOq3E2tveEw6W piktgAjy/ouJH0+7w7HffXmqn8Lbc1iq4ftoUekWbJjfiXl3mS5M3iWibMV0uuGv2wZWG+7gqhmq+ aMF9G3HiB/JqUnZl7/yZv79/ka/Ywq81NGFiNIYFMMCts0ZMzvkKDXr2/xje84coCQ9udXPGuSNnb e4lo5uKHKFhIa/gsEB6UCwO/sMCELus4Av+XtWkF0y/xIerymlMazz9uMgzNbHtqpiO9dCvkKOykq C3bWoBIgpf95JvjImWHPsuGdKRQaMGkzs2f0bsNGC448bGWSiadP/DCrh03ZENJKA0iF6jm3c4zM4 ddrYohyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q8yBQ-007B9W-0z; Tue, 13 Jun 2023 07:11:16 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q8yBN-007B93-2I for barebox@lists.infradead.org; Tue, 13 Jun 2023 07:11:15 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q8yBL-0006tN-Og; Tue, 13 Jun 2023 09:11:11 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1q8yBL-0006oX-Cs; Tue, 13 Jun 2023 09:11:11 +0200 Date: Tue, 13 Jun 2023 09:11:11 +0200 To: Ahmad Fatoum Cc: barebox@lists.infradead.org Message-ID: <20230613071111.GG18491@pengutronix.de> References: <20230612125331.1085059-1-a.fatoum@pengutronix.de> <20230612125331.1085059-6-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612125331.1085059-6-a.fatoum@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) From: Sascha Hauer X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230613_001113_774288_8164AE91 X-CRM114-Status: GOOD ( 12.10 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.7 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH master 6/6] regmap-mmio: fix use-after-free X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On Mon, Jun 12, 2023 at 02:53:31PM +0200, Ahmad Fatoum wrote: > Once we free ctx, dereferencing it to return ERR_CAST(ctx->clk) is > verboten. Fix this by using an intermediary variable. Looks funny like this, but replaced with forbidden for the non german speakers ;) Applied all, thanks Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |