mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org, Jan Palus <jpalus+gnu@fastmail.com>
Subject: Re: [PATCH master] kbuild: Port silent mode detection to future gnu make.
Date: Tue, 13 Jun 2023 10:35:40 +0200	[thread overview]
Message-ID: <20230613083540.GP18491@pengutronix.de> (raw)
In-Reply-To: <7f57920f-a892-57f7-ba06-514951470075@pengutronix.de>

On Tue, Jun 13, 2023 at 10:02:03AM +0200, Ahmad Fatoum wrote:
> On 13.06.23 09:59, Sascha Hauer wrote:
> > On Mon, Jun 12, 2023 at 02:58:24PM +0200, Ahmad Fatoum wrote:
> >> Port silent mode detection to the future (post make-4.4) versions of gnu make.
> >>
> >> Makefile contains the following piece of make code to detect if option -s is
> >> specified on the command line.
> >>
> >> ifneq ($(findstring s,$(filter-out --%,$(MAKEFLAGS))),)
> >>
> >> This code is executed by make at parse time and assumes that MAKEFLAGS
> >> does not contain command line variable definitions.
> >> Currently if the user defines a=s on the command line, then at build only
> >> time MAKEFLAGS contains " -- a=s".
> >> However, starting with commit dc2d963989b96161472b2cd38cef5d1f4851ea34
> > 
> > To which repository does dc2d963989b96161472b2cd38cef5d1f4851ea34
> > belong?
> 
> https://git.savannah.gnu.org/cgit/make.git/commit/?id=dc2d963989b96161472b2cd38cef5d1f4851ea34

Ok. Reworded "commit dc2d963989b96161472b2cd38cef5d1f4851ea34" to:

GNU Make commit dc2d963989b9 ("Always add command line variable
assignments to MAKEFLAGS")

and applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



      reply	other threads:[~2023-06-13  8:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-12 12:58 Ahmad Fatoum
2023-06-13  7:59 ` Sascha Hauer
2023-06-13  8:02   ` Ahmad Fatoum
2023-06-13  8:35     ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230613083540.GP18491@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=jpalus+gnu@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox