From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 14 Jun 2023 12:09:15 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q9NRF-006UJo-5v for lore@lore.pengutronix.de; Wed, 14 Jun 2023 12:09:15 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9NRC-00066r-H2 for lore@pengutronix.de; Wed, 14 Jun 2023 12:09:15 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=phJyfMEhy9QDHre2GmIHAJ684dR87/i4uXJbOlgvqv8=; b=jpMlbmNwYKIrmjDhqJETyLe8p4 Ty/bn6/5BA5TATWXRxtJdJm0rxdMTAHWw0DO21ulPqxt2RCePhTOHrTLz/QgElNetF9enneQ6RR5m EIPv+jraOjvis3FSSEj25huTqdaNmx2DZARq+uDvdiGB9qPnbLIPemBDeRSbRhK6ZZVltzg6y8Mu0 k8YsRVj/q+FrE3AynbhqMtq+m/CLqv83xBU5M3qYl8qfMukbVi9JEcUbtqgUyvR0Cvtgn5TnkepLq SJG3ACru4vZjs0aMjTMulm1ZNo1Zyd4hwizHWNIyySqXrbE2tLCThVghMxQtyMYFSgU/sgR6vYXEk g60cONvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q9NQ7-00BAVh-0x; Wed, 14 Jun 2023 10:08:07 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q9NQ0-00BAQn-2r for barebox@lists.infradead.org; Wed, 14 Jun 2023 10:08:04 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9NPt-0005cS-K6; Wed, 14 Jun 2023 12:07:53 +0200 Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1q9NPs-007KbT-N3; Wed, 14 Jun 2023 12:07:52 +0200 Received: from afa by dude05.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1q9NPr-00E9u8-L7; Wed, 14 Jun 2023 12:07:51 +0200 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: mfe@pengutronix.de, Jules Maselbas , Ahmad Fatoum Date: Wed, 14 Jun 2023 12:07:39 +0200 Message-Id: <20230614100747.3368109-3-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230614100747.3368109-1-a.fatoum@pengutronix.de> References: <20230614100747.3368109-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230614_030800_965703_80DCED6D X-CRM114-Status: GOOD ( 12.48 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.9 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH v2 02/10] gpiolib: simplify for loop break condition X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) From: Marco Felsch No functional change just a simplification to align it with the Linux kernel. Also add the kernel comment to make the reason clear. Signed-off-by: Marco Felsch Reviewed-by: Ahmad Fatoum Signed-off-by: Ahmad Fatoum --- v1 -> v2: - no change --- drivers/gpio/gpiolib.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index b4a3a4e5504c..0df43c9f8f7e 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -529,7 +529,15 @@ static int of_gpiochip_scan_hogs(struct gpio_chip *chip) of_property_read_string_array(chip->dev->of_node, "gpio-line-names", arr, count); - for (i = 0; i < chip->ngpio && i < count; i++) + /* + * Since property 'gpio-line-names' cannot contains gaps, we + * have to be sure we only assign those pins that really exists + * since chip->ngpio can be less. + */ + if (count > chip->ngpio) + count = chip->ngpio; + + for (i = 0; i < count; i++) gpio_desc[chip->base + i].name = xstrdup(arr[i]); free(arr); -- 2.39.2