mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: michael.kopfensteiner@vahle.com
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] common: driver: fixes argument name mismatch in for_each_cdev
Date: Wed, 14 Jun 2023 15:58:57 +0200	[thread overview]
Message-ID: <20230614135857.GY18491@pengutronix.de> (raw)
In-Reply-To: <20230614135133.59312-1-michael.kopfensteiner@vahle.com>

Hi Michael,

On Wed, Jun 14, 2023 at 03:51:33PM +0200, michael.kopfensteiner@vahle.com wrote:
> From: Michael Kopfensteiner <michael.kopfensteiner@vahle.com>
> 
> The for_each_cdev makro takes a pointer argument as loop cursor.
> Due to a name mismatch, not the provided pointer was used but
> whatever was called `cdev`.
> This mismatch had no effect, because in every usage the given
> pointer is named cdev anyway.
> 
> This commit fixes the name-mismatch. The makro now works with
> arguments name differently than 'cdev' too.

Thanks for fixing this. Ahmad was a bit faster though, it is already
fixed in next branch with 7fb4fd0417 ("cdev: fix for_each_cdev macro")

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



      reply	other threads:[~2023-06-14 14:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-14 13:51 michael.kopfensteiner
2023-06-14 13:58 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230614135857.GY18491@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=michael.kopfensteiner@vahle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox