From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 28 Jun 2023 10:47:02 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qEQpM-006vIg-7x for lore@lore.pengutronix.de; Wed, 28 Jun 2023 10:47:02 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qEQpJ-0001WO-F4 for lore@pengutronix.de; Wed, 28 Jun 2023 10:47:02 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:From:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+AHJmkrqv/hFkeJz1oWV7UnWgqczdkruN4e+97H/UzI=; b=h6tJJQ6a5SRtuOI1V7tMkL/gmz sSN3iZLatu0rlvtG5zgTEFgfNSmQk+ECQVSHvbBVafzP0y0RBX3XuJjBEQuRCpG9lIQyTX63f7GMU k+4cdfE7zR719Y6XxDMCxjNR6vacLONz15f9L6t2xOBdzcgnyV5PjQ66mWuhiroQbee8uodib3Vdx rFQs2m/Kxg4PzCwwzRX3kO3IHzkVd+e2PW7xYkl07SI0VrM1PPANaSUHjizAK/EUFdZCTfilZ93gy DvPL62Efo81ebD+PwK9ZuLE3ZM828HMM6RHIO1HNMAC+KFDSXH0XbDYfZ6vXkEHIAUaGOVoKtd+c7 s7QwAaoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qEQnx-00FBhd-2Z; Wed, 28 Jun 2023 08:45:37 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qEQnr-00FBhF-2v for barebox@lists.infradead.org; Wed, 28 Jun 2023 08:45:35 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qEQnp-0001K0-TS; Wed, 28 Jun 2023 10:45:29 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1qEQnp-0005FX-EJ; Wed, 28 Jun 2023 10:45:29 +0200 Date: Wed, 28 Jun 2023 10:45:29 +0200 To: Ahmad Fatoum Cc: barebox@lists.infradead.org, uol@pengutronix.de Message-ID: <20230628084529.GA18491@pengutronix.de> References: <20230627055239.3908872-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230627055239.3908872-1-a.fatoum@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) From: Sascha Hauer X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230628_014531_969355_024C4C1A X-CRM114-Status: GOOD ( 30.83 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.8 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH master v2 0/7] firmware: optionally turn missing firmware errors into warnings X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On Tue, Jun 27, 2023 at 07:52:32AM +0200, Ahmad Fatoum wrote: > v1 -> v2: > - mark firmware used for PBL as pbl-only (fixes unintended build > error) > - fix escape of newline character in firmware/Makefile > - fix build failing even with CONFIG_MISSING_FIRMWARE_ERROR unset Applied, thanks Sascha > > Many of the ARMv8 defconfigs can require firmware external to barebox > for proper operation: TF-A as BL31, DDR PHY firmware, SDRAM setup > or OP-TEE. This led to defconfigs that fail to build by default > unless the user installs the firmware files into the firmware directory. > > While this worked for the SoC-specific defconfigs, it's really annoying > for the multi_v8_defconfig: > > - The user will need to install firmware even for unrelated > platforms > > - Some platforms like e.g. qemu-virt64, which need no firmware to > be compiled into barebox, can't be built just by using the > defconfig > > For v2023.06.0, this was resolved by disabling boards that lack firmware > through hiding their Kconfig symbol. This has a few shortcomings: > > - Firmware is looked up relative to source tree and can't take > CONFIG_EXTRA_FIRMWARE_DIR into account that early > > - Firmware needs to exist at configure stage, which breaks > build system recipes that install firmware after configure > stage > > - menuconfig e.g. in Yocto's cml1.bbclass doesn't take make options > into account that are otherwise used for olddefconfig and build > > This series resolves the underlying issue differently: We record > whether firmware is missing and just continue the build till the end > at which time the build would succeed (with warnings) if new option > CONFIG_MISSING_FIRMWARE_ERROR was unset. > > In any case, barebox images which contain firmware in their PBL > that's not available will be marked specially to reduce the risk > of accidentally putting them to use: > > * They're truncated to zero size > > * The final "images built:" section marks them as having firmware > missing, e.g. ** firmware missing for barebox-rk3568-bpi-r2pro.img** > > * They are omitted from the listing in the barebox-flash-images file > > * Each barebox-broken.img is accompanied with a > barebox-broken.img.missing-firmware containing a newline delimited > list of missing firmware images > > > Ahmad Fatoum (7): > firmware: reference pointer alignment defined in > > firmware: mark firmware used in PBL as pbl-only > firmware: turn missing firmware into linker error > firmware: optionally turn missing firmware errors into warnings > ARM64: Rockchip: gracefully handle missing firmware > ARM64: unset CONFIG_MISSING_FIRMWARE_ERROR for Rockchip/i.MX > firmware: don't hardcode firmware paths in srctree for existence check > > arch/arm/configs/imx_v8_defconfig | 1 + > arch/arm/configs/multi_v8_defconfig | 1 + > arch/arm/configs/rockchip_v8_defconfig | 1 + > arch/arm/mach-imx/Kconfig | 49 ------------------- > arch/arm/mach-rockchip/Kconfig | 6 --- > firmware/Kconfig | 49 +++++-------------- > firmware/Makefile | 47 +++++++++++------- > images/Makefile | 23 ++++++--- > images/Makefile.rockchip | 68 +++++++++----------------- > scripts/Makefile.lib | 3 ++ > 10 files changed, 88 insertions(+), 160 deletions(-) > > -- > 2.39.2 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |