From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH master] firmware: use portable newline escape
Date: Mon, 3 Jul 2023 19:21:34 +0200 [thread overview]
Message-ID: <20230703172133.539183-1-a.fatoum@pengutronix.de> (raw)
We want to print `\n' literally into the *.gen.S file, so gas turns it
into a literal new line character. Depending on shell, the current
scheme might work, but let's play it safe and use single quotes. This
fixes a cosmetic issue of non-escaped `\n' making it into the missing
section on NixOS, which leads to slightly garbled output when firmware
is missing.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
firmware/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/firmware/Makefile b/firmware/Makefile
index 8d3bfb0752ff..5cdff8b85893 100644
--- a/firmware/Makefile
+++ b/firmware/Makefile
@@ -62,7 +62,7 @@ filechk_fwbin = { \
echo "\#ifdef __PBL__" ;\
echo " .section .missing_fw,\"a\"" ;\
echo "_fwname_$(FWSTR):" ;\
- echo ".ascii \"firmware/$(FWNAME)\\\\n\"" ;\
+ echo '.ascii "firmware/$(FWNAME)\n"' ;\
echo "\#endif" ;\
}
--
2.39.2
reply other threads:[~2023-07-03 17:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230703172133.539183-1-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox