From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 04 Jul 2023 13:39:16 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qGeNJ-00Ejhw-FL for lore@lore.pengutronix.de; Tue, 04 Jul 2023 13:39:16 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qGeNH-0001rk-43 for lore@pengutronix.de; Tue, 04 Jul 2023 13:39:15 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:From:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uAx3wmy7oUAYKdDc+YbX2GA3yWrQB6rEx/wC1tn9E3A=; b=pr64sEUMZ6W1fApTuAZYc3sPmj MlAxWeTiw7Mn4HqHWX7WoBihqkrHaeJuo+QcE+2zWqH9n/9/0p1FJOTt9YtE0P0rjfYX5DkBQr2MC Xp/G1WXVFUFi3haUKbtFYdNyZivAcvzKX/VWfnH578SVxM9zdV65vRkwgV4UyBmXXuY1H/15XrDFG YbBbpvrnFwE+/C9yuroJoluOLYN3BTyDFAUveSaQOmqmJ7coEnutaV6ad0oGFZDUE4iqJyTLLrFYM ZuYyPKgKF//jPP0QMLYn28hEpIO4DOvHg/ZmmEaMmM8DjHhAPmImH2wQyoIj2HbihKR+DRZMFxnxV ZBE+jzjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGeMB-00D9PZ-35; Tue, 04 Jul 2023 11:38:07 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGeM9-00D9Ow-0C for barebox@lists.infradead.org; Tue, 04 Jul 2023 11:38:06 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qGeM7-0001ng-JD; Tue, 04 Jul 2023 13:38:03 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1qGeM7-0007hn-Ai; Tue, 04 Jul 2023 13:38:03 +0200 Date: Tue, 4 Jul 2023 13:38:03 +0200 To: Marco Felsch Cc: barebox@lists.infradead.org Message-ID: <20230704113803.GB18491@pengutronix.de> References: <20230704112921.741776-1-m.felsch@pengutronix.de> <20230704112921.741776-2-m.felsch@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230704112921.741776-2-m.felsch@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) From: Sascha Hauer X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230704_043805_105325_D2B0E4DE X-CRM114-Status: GOOD ( 21.26 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.8 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH v2 2/3] commands: test: replace printf with pr_err X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On Tue, Jul 04, 2023 at 01:29:20PM +0200, Marco Felsch wrote: > Replace the printf() with pr_err() to support: > - color formated prints > - logbuffer storing (dmesg) > - loglevels > > Signed-off-by: Marco Felsch > --- > v2: > - new patch > > commands/test.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/commands/test.c b/commands/test.c > index c1b84c42ef..5478011185 100644 > --- a/commands/test.c > +++ b/commands/test.c > @@ -77,7 +77,7 @@ static int do_test(int argc, char *argv[]) > if (*argv[0] == '[') { > argc--; > if (*argv[argc] != ']') { > - printf("[: missing `]'\n"); > + pr_err("[: missing `]'\n"); Logging functions pr_* and dev_* should be used for core and driver messages, commands should use printf. The line between logging functions and commands is not always clear in barebox, but here it is. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |