From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 25 Jul 2023 22:36:20 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qOOlZ-009orn-UW for lore@lore.pengutronix.de; Tue, 25 Jul 2023 22:36:20 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qOOlX-0008BA-I2 for lore@pengutronix.de; Tue, 25 Jul 2023 22:36:20 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=IDNjirKSk4CIIBE3A5kuDCzlS14XLQxYU3dbg7/TfYg=; b=EEeN+fYD/LC0OYa5AXdz43aiF0 ifBo/smZZz08oX6izXt85aQmycWuXZlm8kAeKKbYALlTtSDTn26V4N1rQuBuXfXZPOQxxesgGBVxd koIeuk+vPCobhOjPtXdQoE/6NOy7iXfSZLzRRYxWEvLyglSjyel9jkUe2ZrbM/Q5uqxxKhMEndn7I FC88jng0xeOF/xMcN6lb+VbMVt77Nt8t+mW8GMH0n84gnepT451VLcX4IE2VOpqhoaVFjvw+/hxD7 iosbKsOqKYEUYiPEq1yOrZKPPL15vH9RRXyV3wP9CaMgadeyXljc76slfshxkwHNNp1MjL3VKIpUb ytuwsD6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qOOk9-008Rg3-1q; Tue, 25 Jul 2023 20:34:53 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qOOk5-008RfM-1H for barebox@lists.infradead.org; Tue, 25 Jul 2023 20:34:51 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qOOjy-0007np-GB; Tue, 25 Jul 2023 22:34:42 +0200 Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1qOOjx-00257K-Rd; Tue, 25 Jul 2023 22:34:41 +0200 Received: from afa by dude05.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1qOOjx-004QnU-1a; Tue, 25 Jul 2023 22:34:41 +0200 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum Date: Tue, 25 Jul 2023 22:34:38 +0200 Message-Id: <20230725203438.1056307-1-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230725_133449_453791_7D415149 X-CRM114-Status: GOOD ( 10.23 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.9 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH] drivers: hab: work-around GCC -Wmaybe-uninitialized false-positive X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) imx_hab_read_srk_hash() always initializes the buffer that's passed in fully. Yet, gcc-13.1.1 warns that this is not always the case, but inlining imx_hab_read_srk_hash() makes the false-positive warning disappear. Pacify GCC by just zero-initializing the 256-bit srk buffer. Signed-off-by: Ahmad Fatoum --- drivers/hab/hab.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hab/hab.c b/drivers/hab/hab.c index 5bb97c4b689b..fad367f43dfb 100644 --- a/drivers/hab/hab.c +++ b/drivers/hab/hab.c @@ -318,7 +318,7 @@ int imx_hab_write_srk_hash_hex(const char *srkhash, unsigned flags) int imx_hab_lockdown_device(unsigned flags) { struct imx_hab_ops *ops = imx_get_hab_ops(); - u8 srk[SRK_HASH_SIZE]; + u8 srk[SRK_HASH_SIZE] = {}; int ret; ret = imx_hab_read_srk_hash(srk); -- 2.39.2