[PATCH] drivers: hab: work-around GCC -Wmaybe-uninitialized false-positive

[PATCH] drivers: hab: work-around GCC -Wmaybe-uninitialized false-positive

[Ahmad Fatoum]

imx_hab_read_srk_hash() always initializes the buffer that's passed in
fully. Yet, gcc-13.1.1 warns that this is not always the case, but
inlining imx_hab_read_srk_hash() makes the false-positive warning disappear.
Pacify GCC by just zero-initializing the 256-bit srk buffer.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/hab/hab.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hab/hab.c b/drivers/hab/hab.c
index 5bb97c4b689b..fad367f43dfb 100644
--- a/drivers/hab/hab.c
+++ b/drivers/hab/hab.c
@@ -318,7 +318,7 @@ int imx_hab_write_srk_hash_hex(const char *srkhash, unsigned flags)
 int imx_hab_lockdown_device(unsigned flags)
 {
 	struct imx_hab_ops *ops = imx_get_hab_ops();
-	u8 srk[SRK_HASH_SIZE];
+	u8 srk[SRK_HASH_SIZE] = {};
 	int ret;
 
 	ret = imx_hab_read_srk_hash(srk);
-- 
2.39.2

Re: [PATCH] drivers: hab: work-around GCC -Wmaybe-uninitialized false-positive

[Sascha Hauer]

On Tue, Jul 25, 2023 at 10:34:38PM +0200, Ahmad Fatoum wrote:
> imx_hab_read_srk_hash() always initializes the buffer that's passed in
> fully. Yet, gcc-13.1.1 warns that this is not always the case, but
> inlining imx_hab_read_srk_hash() makes the false-positive warning disappear.
> Pacify GCC by just zero-initializing the 256-bit srk buffer.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/hab/hab.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/hab/hab.c b/drivers/hab/hab.c
> index 5bb97c4b689b..fad367f43dfb 100644
> --- a/drivers/hab/hab.c
> +++ b/drivers/hab/hab.c
> @@ -318,7 +318,7 @@ int imx_hab_write_srk_hash_hex(const char *srkhash, unsigned flags)
>  int imx_hab_lockdown_device(unsigned flags)
>  {
>  	struct imx_hab_ops *ops = imx_get_hab_ops();
> -	u8 srk[SRK_HASH_SIZE];
> +	u8 srk[SRK_HASH_SIZE] = {};
>  	int ret;
>  
>  	ret = imx_hab_read_srk_hash(srk);
> -- 
> 2.39.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |