From: Sascha Hauer <sha@pengutronix.de>
To: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] rsa: escape pkcs11 string passed to RSA command
Date: Wed, 26 Jul 2023 12:14:55 +0200 [thread overview]
Message-ID: <20230726101455.GJ18491@pengutronix.de> (raw)
In-Reply-To: <20230719134630.174215-1-r.czerwinski@pengutronix.de>
On Wed, Jul 19, 2023 at 03:46:30PM +0200, Rouven Czerwinski wrote:
> Escape the pkcs11 string that can be passed to the rsatoc script.
> Otherwise the sh -c invocation for commands will interpret the pkcs11
> URI semicolon separator as the end of the command.
>
> Fixes: b39100bcea12 ("rsa: Allow to directly compile in rsa public keys")
>
> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> ---
> scripts/Makefile.lib | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index f04c09f9e2..fe77c83ba2 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -625,7 +625,7 @@ quiet_cmd_b64dec = B64DEC $@
> # target file.
> quiet_cmd_rsa_keys = RSAKEY $@
> cmd_rsa_keys = \
> - $(objtree)/scripts/rsatoc -o $@.tmp $(2) && \
> + $(objtree)/scripts/rsatoc -o $@.tmp "$(2)" && \
> if cmp -s $@.tmp $@; then \
> rm $@.tmp; \
> else \
> --
> 2.41.0
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2023-07-26 10:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 13:46 Rouven Czerwinski
2023-07-26 10:14 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230726101455.GJ18491@pengutronix.de \
--to=sha@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=r.czerwinski@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox