From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 1/4] commands: hab: check for error in imx_hab_device_locked_down
Date: Wed, 26 Jul 2023 21:27:15 +0200 [thread overview]
Message-ID: <20230726192718.911735-1-a.fatoum@pengutronix.de> (raw)
imx_hab_device_locked_down() reads efuses and that operation can fail.
Instead of assuming a failure means the efuses are non-zero, have the
hab command explicitly check for negative error codes.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
commands/hab.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/commands/hab.c b/commands/hab.c
index 97a1701fa551..8ae943a4c880 100644
--- a/commands/hab.c
+++ b/commands/hab.c
@@ -58,7 +58,13 @@ static int do_hab(int argc, char *argv[])
printf("%02x", srk[i]);
printf("\n");
- if (imx_hab_device_locked_down())
+ ret = imx_hab_device_locked_down();
+ if (ret < 0) {
+ printf("failed to determine lockdown mode: '%pe'\n", ERR_PTR(ret));
+ return ret;
+ }
+
+ if (ret)
printf("secure mode\n");
else
printf("devel mode\n");
--
2.39.2
next reply other threads:[~2023-07-26 19:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 19:27 Ahmad Fatoum [this message]
2023-07-26 19:27 ` [PATCH 2/4] HAB: guard against NULL imx_hab_ops in imx_hab_device_locked_down() Ahmad Fatoum
2023-07-26 19:27 ` [PATCH 3/4] nvmem: ocotp: handle too early calls into ocotp driver gracefully Ahmad Fatoum
2023-07-27 6:05 ` Marco Felsch
2023-07-27 6:26 ` Ahmad Fatoum
2023-07-26 19:27 ` [PATCH 4/4] hab: habv4: export function to query HAB state Ahmad Fatoum
2023-07-27 6:05 ` [PATCH 1/4] commands: hab: check for error in imx_hab_device_locked_down Marco Felsch
2023-07-28 6:09 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230726192718.911735-1-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox