From: Marco Felsch <m.felsch@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/4] commands: hab: check for error in imx_hab_device_locked_down
Date: Thu, 27 Jul 2023 08:05:31 +0200 [thread overview]
Message-ID: <20230727060531.hfsrhjgyt3qizy3k@pengutronix.de> (raw)
In-Reply-To: <20230726192718.911735-1-a.fatoum@pengutronix.de>
On 23-07-26, Ahmad Fatoum wrote:
> imx_hab_device_locked_down() reads efuses and that operation can fail.
> Instead of assuming a failure means the efuses are non-zero, have the
> hab command explicitly check for negative error codes.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Feel free to add my r-b for the whole series.
Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
next prev parent reply other threads:[~2023-07-27 6:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 19:27 Ahmad Fatoum
2023-07-26 19:27 ` [PATCH 2/4] HAB: guard against NULL imx_hab_ops in imx_hab_device_locked_down() Ahmad Fatoum
2023-07-26 19:27 ` [PATCH 3/4] nvmem: ocotp: handle too early calls into ocotp driver gracefully Ahmad Fatoum
2023-07-27 6:05 ` Marco Felsch
2023-07-27 6:26 ` Ahmad Fatoum
2023-07-26 19:27 ` [PATCH 4/4] hab: habv4: export function to query HAB state Ahmad Fatoum
2023-07-27 6:05 ` Marco Felsch [this message]
2023-07-28 6:09 ` [PATCH 1/4] commands: hab: check for error in imx_hab_device_locked_down Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230727060531.hfsrhjgyt3qizy3k@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox