From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH v2] commands: rm: add -f option to ignore nonexistent files
Date: Thu, 3 Aug 2023 15:43:32 +0200 [thread overview]
Message-ID: <20230803134332.1763059-1-a.fatoum@pengutronix.de> (raw)
rm supports multiple arguments, but will stop at the first nonexistent
file and print an error message that can't be silenced. Mimic other
implementations and implement -f for silently ignoring nonexistent files.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
v1 -> v2:
- only ignore -ENOENT and not all error codes
---
commands/Kconfig | 3 ++-
commands/rm.c | 16 +++++++++++-----
2 files changed, 13 insertions(+), 6 deletions(-)
diff --git a/commands/Kconfig b/commands/Kconfig
index 844f7046282b..eb95b2a5fbcc 100644
--- a/commands/Kconfig
+++ b/commands/Kconfig
@@ -1031,10 +1031,11 @@ config CMD_RM
help
Remove files
- Usage: rm [-r] FILES...
+ Usage: rm [-rf] FILES...
Options:
-r remove directories and their contents recursively
+ -f ignore nonexistent files
config CMD_RMDIR
tristate
diff --git a/commands/rm.c b/commands/rm.c
index be5c19222141..c35cf2d2d412 100644
--- a/commands/rm.c
+++ b/commands/rm.c
@@ -12,13 +12,16 @@
static int do_rm(int argc, char *argv[])
{
- int i, opt, recursive = 0;
+ int i, opt, recursive = 0, force = 0;
- while ((opt = getopt(argc, argv, "r")) > 0) {
+ while ((opt = getopt(argc, argv, "rf")) > 0) {
switch (opt) {
case 'r':
recursive = 1;
break;
+ case 'f':
+ force = 1;
+ break;
default:
return COMMAND_ERROR_USAGE;
}
@@ -37,8 +40,10 @@ static int do_rm(int argc, char *argv[])
else
ret = unlink(argv[i]);
if (ret) {
- printf("could not remove %s: %m\n", argv[i]);
- return 1;
+ if (!force || ret != -ENOENT)
+ printf("could not remove %s: %m\n", argv[i]);
+ if (!force)
+ return 1;
}
i++;
}
@@ -49,12 +54,13 @@ static int do_rm(int argc, char *argv[])
BAREBOX_CMD_HELP_START(rm)
BAREBOX_CMD_HELP_TEXT("Options:")
BAREBOX_CMD_HELP_OPT ("-r", "remove directories and their contents recursively")
+BAREBOX_CMD_HELP_OPT ("-f", "ignore nonexistent files")
BAREBOX_CMD_HELP_END
BAREBOX_CMD_START(rm)
.cmd = do_rm,
BAREBOX_CMD_DESC("remove files")
- BAREBOX_CMD_OPTS("[-r] FILES...")
+ BAREBOX_CMD_OPTS("[-rf] FILES...")
BAREBOX_CMD_GROUP(CMD_GRP_FILE)
BAREBOX_CMD_HELP(cmd_rm_help)
BAREBOX_CMD_END
--
2.39.2
next reply other threads:[~2023-08-03 13:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 13:43 Ahmad Fatoum [this message]
2023-08-04 8:34 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230803134332.1763059-1-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox