From: Marco Felsch <m.felsch@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH] of: of_net: add support to parse ASCII encoded mac-addresses
Date: Mon, 7 Aug 2023 19:07:43 +0200 [thread overview]
Message-ID: <20230807170743.149799-1-m.felsch@pengutronix.de> (raw)
Some vendors like Polyhex store the MAC address ASCII encoded instead of
using the plain 6-byte MAC address. This commit adds the support to
decode the 12-byte ASCII encoded MAC addresses.
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
drivers/of/of_net.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/drivers/of/of_net.c b/drivers/of/of_net.c
index 75a24073da51..4e74986cdda8 100644
--- a/drivers/of/of_net.c
+++ b/drivers/of/of_net.c
@@ -79,6 +79,8 @@ static int of_get_mac_addr(struct device_node *np, const char *name, u8 *addr)
return -ENODEV;
}
+#define ETH_ALEN_ASCII 12
+
int of_get_mac_addr_nvmem(struct device_node *np, u8 *addr)
{
struct nvmem_cell *cell;
@@ -98,6 +100,23 @@ int of_get_mac_addr_nvmem(struct device_node *np, u8 *addr)
if (IS_ERR(mac))
return PTR_ERR(mac);
+ if (len == ETH_ALEN_ASCII) {
+ u8 *mac_new;
+ int ret;
+
+ mac_new = kzalloc(sizeof("xx:xx:xx:xx:xx:xx"), GFP_KERNEL);
+ ret = hex2bin(mac_new, mac, ETH_ALEN);
+ if (ret) {
+ kfree(mac_new);
+ kfree(mac);
+ return ret;
+ }
+
+ kfree(mac);
+ mac = mac_new;
+ len = ETH_ALEN;
+ }
+
if (len != ETH_ALEN || !is_valid_ether_addr(mac)) {
kfree(mac);
return -EINVAL;
--
2.39.2
next reply other threads:[~2023-08-07 17:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 17:07 Marco Felsch [this message]
2023-08-08 5:51 ` Sascha Hauer
2023-08-08 7:58 ` Marco Felsch
2023-08-08 9:36 ` Ahmad Fatoum
2023-08-08 9:46 ` Marco Felsch
2023-08-08 10:23 ` Ahmad Fatoum
2023-08-08 16:20 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230807170743.149799-1-m.felsch@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox