From: Oleksij Rempel <o.rempel@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Oleksij Rempel <o.rempel@pengutronix.de>
Subject: [PATCH v2 3/5] net: designware: eqos: add comment about external clock dependencies for the soft reset
Date: Mon, 14 Aug 2023 07:32:27 +0200 [thread overview]
Message-ID: <20230814053229.2311097-4-o.rempel@pengutronix.de> (raw)
In-Reply-To: <20230814053229.2311097-1-o.rempel@pengutronix.de>
This part of code is not error proof and may fail depending on
implementation state of external HW. I hope this note help to find bugs
later.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
drivers/net/designware_eqos.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/designware_eqos.c b/drivers/net/designware_eqos.c
index 6caf3a436f..4489725e87 100644
--- a/drivers/net/designware_eqos.c
+++ b/drivers/net/designware_eqos.c
@@ -427,6 +427,10 @@ static int eqos_start(struct eth_device *edev)
if (ret)
return ret;
+ /* In some cases where PHY or DSA switch is the clock provider for
+ * EQOS, we need to probe and configure them before issuing software
+ * reset here.
+ */
setbits_le32(&eqos->dma_regs->mode, EQOS_DMA_MODE_SWR);
ret = readl_poll_timeout(&eqos->dma_regs->mode, mode_set,
--
2.39.2
next prev parent reply other threads:[~2023-08-14 5:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 5:32 [PATCH v2 0/5] net: designware: eqos: fixes Oleksij Rempel
2023-08-14 5:32 ` [PATCH v2 1/5] net: designware: eqos: initialize MAC address specific DMA channel configuration Oleksij Rempel
2023-08-14 5:32 ` [PATCH v2 2/5] net: designware: eqos: fix non-working promisc mode when set before interface start Oleksij Rempel
2023-08-14 5:32 ` Oleksij Rempel [this message]
2023-08-14 5:32 ` [PATCH v2 4/5] net: designware: eqos: fix NULL pointer dereference on LLDP packets Oleksij Rempel
2023-08-14 5:32 ` [PATCH v2 5/5] net: designware: eqos: do not receive pause frames Oleksij Rempel
2023-08-14 13:04 ` [PATCH v2 0/5] net: designware: eqos: fixes Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230814053229.2311097-4-o.rempel@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox