Re: [PATCH v1] ARM: add Skov i'MX8MP based board support

[Oleksij Rempel <o.rempel@pengutronix.de>]

Hallo Ahmad,

On Fri, Aug 11, 2023 at 02:50:07PM +0200, Ahmad Fatoum wrote:
> Hello Oleksij,
> 
> On 11.08.23 13:48, Oleksij Rempel wrote:
> > +static const struct of_device_id skov_imx8m_of_match[] = {
> > +	{ .compatible = "skov,imx8mp" },
> 
> Are you sure, you don't want to have a -someboard suffix in case you need
> to differentiate future variants?

Yes, it is same way as it is done for the skov,imx6 boards. There is one
in barebox devicetree which is generic for all. Then board code reads
version from gpio pins and detect precise version.

This patch provide only initial support, version detection will be added
later.

> 
> > +	pmic@25 {
> > +		compatible = "nxp,pca9450c";
> 
> FYI, there is a driver here:
> https://lore.barebox.org/barebox/20230724075258.1840671-1-h.assmann@pengutronix.de/
> 
> That would allow you to get $global.system.reset if that's something that's
> intereting to you.

Yes, this can be added later if needed.

> 
> > +config MACH_SKOV_IMX8M
> > +	bool "Skov IMX8Mx based boards"
> > +	select ARCH_IMX8MP
> > +	select FIRMWARE_IMX_LPDDR4_PMU_TRAIN
> > +	select FIRMWARE_IMX8MP_ATF
> > +	select ARM_SMCCC
> > +	select MCI_IMX_ESDHC_PBL
> > +	select IMX8M_DRAM
> > +	select I2C_IMX_EARLY
> > +	select DSA
> > +	select DRIVER_NET_KSZ9477
> 
> Please drop last two selects. You should only select what's actually required
> for booting. At most, you could do an imply here. Also, please enable in defconfig
> for compile coverage. There you can enable DSA and KSZ9477 support.

Ok.

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |