mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Roland Hieber <rhi@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] commands: global: document usage without parameters
Date: Wed, 16 Aug 2023 11:40:52 +0200	[thread overview]
Message-ID: <20230816094052.GD5650@pengutronix.de> (raw)
In-Reply-To: <20230814141112.567070-1-rhi@pengutronix.de>

On Mon, Aug 14, 2023 at 04:11:13PM +0200, Roland Hieber wrote:
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
>  commands/global.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/commands/global.c b/commands/global.c
> index cf8e9a5b4894..a8ff5ea18fb0 100644
> --- a/commands/global.c
> +++ b/commands/global.c
> @@ -50,6 +50,7 @@ static int do_global(int argc, char *argv[])
>  
>  BAREBOX_CMD_HELP_START(global)
>  BAREBOX_CMD_HELP_TEXT("Add a new global variable named VAR, optionally set to VALUE.")
> +BAREBOX_CMD_HELP_TEXT("Without options, print all global and env (prefixed with *) variables.")
>  BAREBOX_CMD_HELP_TEXT("")
>  BAREBOX_CMD_HELP_TEXT("Options:")
>  BAREBOX_CMD_HELP_OPT("-r", "Remove globalvars")
> @@ -58,7 +59,7 @@ BAREBOX_CMD_HELP_END
>  BAREBOX_CMD_START(global)
>  	.cmd		= do_global,
>  	BAREBOX_CMD_DESC("create or set global variables")
> -	BAREBOX_CMD_OPTS("[-r] VAR[=VALUE] ...")
> +	BAREBOX_CMD_OPTS("[-r] [VAR[=VALUE] ...]")
>  	BAREBOX_CMD_GROUP(CMD_GRP_ENV)
>  	BAREBOX_CMD_HELP(cmd_global_help)
>  	BAREBOX_CMD_COMPLETE(global_complete)
> -- 
> 2.39.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



      reply	other threads:[~2023-08-16  9:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-14 14:11 Roland Hieber
2023-08-16  9:40 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230816094052.GD5650@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=rhi@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox