From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 17 Aug 2023 11:34:59 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qWZPA-007mbL-DJ for lore@lore.pengutronix.de; Thu, 17 Aug 2023 11:34:59 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qWZP8-0005cu-EI for lore@pengutronix.de; Thu, 17 Aug 2023 11:34:58 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=S445FmCXpAag13sibQRHhVHMMqGsFvCdpsvG+A4XEXQ=; b=h1+EoSB27RKip6RAie5ZJseUNz b7x5AjUy6kb5PxZX3rCB6OPxBhNkABxcDcK9oD7TJRmuExt/vKWOAdc0T+NZTiBKg5LWpZWry105h n/uzsMfb2TJB8yKV3rFDXqZtTy1J28qyVArLfAENyl0RUV4LtAvS+ojB2y5WTVdRze0+o90xQBEJS nVjuoL+DKfHyiYK8A23IT7Mr5vHQM5b2DoupbLyVHUhxb1fgynh7EToEYmXhbiTXZ7x8vEFKfqBhm RwKU3ZOlW+QB+ar+cInRzmfyhpZ+SpSoTTzTdYH6ToSyIr1ipWoJyZpWkJTQg4v88Irpc4e7YzJdi btXddz6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qWZNn-005wjw-1D; Thu, 17 Aug 2023 09:33:35 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qWZNk-005wjQ-0v for barebox@lists.infradead.org; Thu, 17 Aug 2023 09:33:33 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qWZNf-0005M0-Qv; Thu, 17 Aug 2023 11:33:27 +0200 Received: from mfe by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1qWZNf-0000AT-JW; Thu, 17 Aug 2023 11:33:27 +0200 Date: Thu, 17 Aug 2023 11:33:27 +0200 From: Marco Felsch To: Ahmad Fatoum Cc: barebox@lists.infradead.org Message-ID: <20230817093327.egxowoew2afto5mu@pengutronix.de> References: <20230817073941.1261154-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230817073941.1261154-1-a.fatoum@pengutronix.de> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230817_023332_341985_043AD6BF X-CRM114-Status: UNSURE ( 7.40 ) X-CRM114-Notice: Please train this message. X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.7 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH master 1/3] envfs: fix defaultenv_append_directory macro definition X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On 23-08-17, Ahmad Fatoum wrote: > defaultenv_append_directory is called as if it were a function and the > trailing semicolon can break parse of if-else statements. Wrap in do { } > while (0) to avoid this. > > Signed-off-by: Ahmad Fatoum Reviewed-by: Marco Felsch