From: Marco Felsch <m.felsch@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH v2] ARM: i.MX8M: esdctl: split memory banks for devices with >4G
Date: Thu, 31 Aug 2023 16:47:24 +0200 [thread overview]
Message-ID: <20230831144724.3424405-1-m.felsch@pengutronix.de> (raw)
At the moment the whole available memory is added to one single memory
bank "ram0". This can cause barebox chainload issues on devices with a
huge amount of memory like the i.MX8MP-EVK which has 6G of RAM if the
barebox pbl binary is to large.
The reason for this issues is that memory_bank_first_find_space()
returns the memory area with the largest amount of free space on the
first memory bank. So in case of Debix SOM-A 8G and i.MX8MP-EVK 6G this
is the area crossing the 4G boundary. This cause the barebox pbl code to
trigger a MMU exception once the early MMU gets enabled which is
configured for sizes <=4G.
Split the memory space into two memory banks: "ram0" and "ram1" to fix
this issue.
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
v2:
- drop add_mem() usage and use arm_add_mem_device() directly
arch/arm/mach-imx/esdctl.c | 23 +++++++++++++++++++----
1 file changed, 19 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-imx/esdctl.c b/arch/arm/mach-imx/esdctl.c
index 1798ad48e50a..7f313b2337ae 100644
--- a/arch/arm/mach-imx/esdctl.c
+++ b/arch/arm/mach-imx/esdctl.c
@@ -510,16 +510,31 @@ static resource_size_t imx8m_ddrc_sdram_size(void __iomem *ddrc, unsigned buswid
reduced_adress_space, mstr);
}
+static int _imx8m_ddrc_add_mem(void *mmdcbase, struct imx_esdctl_data *data,
+ unsigned int buswidth)
+{
+ resource_size_t size = imx8m_ddrc_sdram_size(mmdcbase, buswidth);
+ resource_size_t size0, size1;
+ int ret;
+
+ size0 = min_t(resource_size_t, SZ_4G - MX8M_DDR_CSD1_BASE_ADDR, size);
+ size1 = size - size0;
+
+ ret = arm_add_mem_device("ram0", data->base0, size0);
+ if (ret || size1 == 0)
+ return ret;
+
+ return arm_add_mem_device("ram1", SZ_4G, size1);
+}
+
static int imx8m_ddrc_add_mem(void *mmdcbase, struct imx_esdctl_data *data)
{
- return arm_add_mem_device("ram0", data->base0,
- imx8m_ddrc_sdram_size(mmdcbase, 32));
+ return _imx8m_ddrc_add_mem(mmdcbase, data, 32);
}
static int imx8mn_ddrc_add_mem(void *mmdcbase, struct imx_esdctl_data *data)
{
- return arm_add_mem_device("ram0", data->base0,
- imx8m_ddrc_sdram_size(mmdcbase, 16));
+ return _imx8m_ddrc_add_mem(mmdcbase, data, 16);
}
static resource_size_t imx7d_ddrc_sdram_size(void __iomem *ddrc)
--
2.39.2
next reply other threads:[~2023-08-31 14:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 14:47 Marco Felsch [this message]
2023-09-04 10:02 ` Sascha Hauer
2023-09-05 8:11 ` Marco Felsch
2023-09-04 14:44 ` Ahmad Fatoum
2023-09-05 8:10 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230831144724.3424405-1-m.felsch@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox