From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 05 Sep 2023 10:11:23 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qdR9g-004jFF-HE for lore@lore.pengutronix.de; Tue, 05 Sep 2023 10:11:23 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qdR9e-0007UW-Em for lore@pengutronix.de; Tue, 05 Sep 2023 10:11:23 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xHj/lTQFGcR49iHy2q2aOezBeJSLfzWNS5BcAuXybOM=; b=4A6c+efM4NdcfZItNVlLLMCfka snc8faxQ+eHTMLdtQAI2zIFzPnCnFJ26S/nXp2RCANUY12g1Dlx5+Ff8DdViU2rPGyxwbRetDlf7L Eo4kg4eVu0B0x0f/WHMwJYGOO/4S4vpl7vvf0QKXZxRWjpG/XSOdPf3UVQzPRFO30xAo4qc64i/MS nnlwvpHlW4l1pjdNGZbtyLtX7Cj8wySaY/kcaLTD+qVDdMHqckU0b07NnsKxfDIMH5Iz1+HDKzpV0 dDgKqJtFn7W9cRz906BNYiwe8CQ8MqcO/uL+PqOlIKguUp6bzgABwiMDUqPv+Uc2zqoJKOxDsmhij JjgcRtiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qdR8R-005Uth-2T; Tue, 05 Sep 2023 08:10:07 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qdR8O-005Usn-24 for barebox@lists.infradead.org; Tue, 05 Sep 2023 08:10:06 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qdR8L-0006nL-0R; Tue, 05 Sep 2023 10:10:01 +0200 Received: from [2a0a:edc0:2:b01:1d::c0] (helo=ptx.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qdR8K-0044lh-KS; Tue, 05 Sep 2023 10:10:00 +0200 Received: from mfe by ptx.whiteo.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1qdR8K-001WU9-8T; Tue, 05 Sep 2023 10:10:00 +0200 Date: Tue, 5 Sep 2023 10:10:00 +0200 From: Marco Felsch To: Ahmad Fatoum Cc: barebox@lists.infradead.org Message-ID: <20230905081000.mqk2wfum5d4zhuck@pengutronix.de> References: <20230831144724.3424405-1-m.felsch@pengutronix.de> <8b7680a0-5d97-411f-e7e1-ae1dd8e26d71@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8b7680a0-5d97-411f-e7e1-ae1dd8e26d71@pengutronix.de> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230905_011004_701284_E43EFDF5 X-CRM114-Status: GOOD ( 28.40 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.0 required=4.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH v2] ARM: i.MX8M: esdctl: split memory banks for devices with >4G X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On 23-09-04, Ahmad Fatoum wrote: > On 31.08.23 16:47, Marco Felsch wrote: > > At the moment the whole available memory is added to one single memory > > bank "ram0". This can cause barebox chainload issues on devices with a > > huge amount of memory like the i.MX8MP-EVK which has 6G of RAM if the > > barebox pbl binary is to large. > > > > The reason for this issues is that memory_bank_first_find_space() > > returns the memory area with the largest amount of free space on the > > first memory bank. So in case of Debix SOM-A 8G and i.MX8MP-EVK 6G this > > is the area crossing the 4G boundary. This cause the barebox pbl code to > > trigger a MMU exception once the early MMU gets enabled which is > > configured for sizes <=4G. > > > > Split the memory space into two memory banks: "ram0" and "ram1" to fix > > this issue. > > > > Signed-off-by: Marco Felsch > > --- > > v2: > > - drop add_mem() usage and use arm_add_mem_device() directly > > > > arch/arm/mach-imx/esdctl.c | 23 +++++++++++++++++++---- > > 1 file changed, 19 insertions(+), 4 deletions(-) > > > > diff --git a/arch/arm/mach-imx/esdctl.c b/arch/arm/mach-imx/esdctl.c > > index 1798ad48e50a..7f313b2337ae 100644 > > --- a/arch/arm/mach-imx/esdctl.c > > +++ b/arch/arm/mach-imx/esdctl.c > > @@ -510,16 +510,31 @@ static resource_size_t imx8m_ddrc_sdram_size(void __iomem *ddrc, unsigned buswid > > reduced_adress_space, mstr); > > } > > > > +static int _imx8m_ddrc_add_mem(void *mmdcbase, struct imx_esdctl_data *data, > > + unsigned int buswidth) > > +{ > > + resource_size_t size = imx8m_ddrc_sdram_size(mmdcbase, buswidth); > > + resource_size_t size0, size1; > > + int ret; > > + > > + size0 = min_t(resource_size_t, SZ_4G - MX8M_DDR_CSD1_BASE_ADDR, size); > > + size1 = size - size0; > > + > > + ret = arm_add_mem_device("ram0", data->base0, size0); > > + if (ret || size1 == 0) > > + return ret; > > + > > + return arm_add_mem_device("ram1", SZ_4G, size1); > > This gives a warning when compiling the file for 32-bit, because resource_size_t > is 32-bit there, while SZ_4G is always an unsigned long long. Thanks for this info. Size >= 4G on 32-bit systems is useless anyways. I will guard this by an #ifdef CONFIG_64BIT and add a comment. Regards, Marco > > > +} > > + > > static int imx8m_ddrc_add_mem(void *mmdcbase, struct imx_esdctl_data *data) > > { > > - return arm_add_mem_device("ram0", data->base0, > > - imx8m_ddrc_sdram_size(mmdcbase, 32)); > > + return _imx8m_ddrc_add_mem(mmdcbase, data, 32); > > } > > > > static int imx8mn_ddrc_add_mem(void *mmdcbase, struct imx_esdctl_data *data) > > { > > - return arm_add_mem_device("ram0", data->base0, > > - imx8m_ddrc_sdram_size(mmdcbase, 16)); > > + return _imx8m_ddrc_add_mem(mmdcbase, data, 16); > > } > > > > static resource_size_t imx7d_ddrc_sdram_size(void __iomem *ddrc) > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > >