From: Gerald Loacker <gerald.loacker@wolfvision.net>
To: barebox@lists.infradead.org
Cc: Gerald Loacker <gerald.loacker@wolfvision.net>
Subject: [PATCH 2/4] i2c: rockchip: ignore i2c transfers when another transfer is running
Date: Fri, 08 Sep 2023 12:16:47 +0200 [thread overview]
Message-ID: <20230908-bugfix-i2c-rockchip-v1-2-f8235d811f6b@wolfvision.net> (raw)
In-Reply-To: <20230908-bugfix-i2c-rockchip-v1-0-f8235d811f6b@wolfvision.net>
It may happen that an i2c transfer is requested by a callback although
there is an other i2c transfer running. In this case do not interrupt the
transfer and return with an error.
Signed-off-by: Gerald Loacker <gerald.loacker@wolfvision.net>
---
drivers/i2c/busses/i2c-rockchip.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-rockchip.c b/drivers/i2c/busses/i2c-rockchip.c
index 1bca3e9913..a869b9d0b7 100644
--- a/drivers/i2c/busses/i2c-rockchip.c
+++ b/drivers/i2c/busses/i2c-rockchip.c
@@ -369,7 +369,19 @@ static int rockchip_i2c_xfer(struct i2c_adapter *adapter, struct i2c_msg *msgs,
{
struct rk_i2c *i2c = to_rk_i2c(adapter);
struct device *dev = &adapter->dev;
- int i, ret = 0;
+ struct i2c_regs *regs = i2c->regs;
+ int i, ret = 0, val;
+
+ val = readl(®s->con);
+ if (val & I2C_CON_EN) {
+ val = readl(®s->con);
+ if (val & I2C_IPD_ALL_CLEAN) {
+ dev_dbg(dev,
+ "i2c_xfer: %d messages dropped due to pending interrupts\n",
+ nmsgs);
+ return -EAGAIN;
+ }
+ }
dev_dbg(dev, "i2c_xfer: %d messages\n", nmsgs);
for (i = 0; i < nmsgs; i++) {
--
2.37.2
next prev parent reply other threads:[~2023-09-08 11:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 10:16 [PATCH 0/4] Fix rockchip I2C bus Gerald Loacker
2023-09-08 10:16 ` [PATCH 1/4] i2c: rockchip: fix i2c stop condition Gerald Loacker
2023-09-08 13:53 ` Sascha Hauer
2023-09-12 5:45 ` Gerald Loacker
2023-09-12 6:03 ` Sascha Hauer
2023-09-08 10:16 ` Gerald Loacker [this message]
2023-09-08 11:51 ` [PATCH 2/4] i2c: rockchip: ignore i2c transfers when another transfer is running Sascha Hauer
2023-09-08 11:55 ` Sascha Hauer
2023-09-08 13:13 ` Sascha Hauer
2023-09-11 11:46 ` Gerald Loacker
2023-09-08 10:16 ` [PATCH 3/4] net: ksz9477: propagate phy read error Gerald Loacker
2023-09-08 11:59 ` Ahmad Fatoum
2023-09-08 12:32 ` Oleksij Rempel
2023-09-08 10:16 ` [PATCH 4/4] net: ksz9477: propagate phy write error Gerald Loacker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230908-bugfix-i2c-rockchip-v1-2-f8235d811f6b@wolfvision.net \
--to=gerald.loacker@wolfvision.net \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox