mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] include: linux/kernel.h: define PTR_ALIGN_DOWN/PTR_IS_ALIGNED
@ 2023-09-11 10:16 Ahmad Fatoum
  2023-09-12  9:29 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2023-09-11 10:16 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

Pointer casts to integers are a common cause of 64-bit incompatibilities.
Import PTR_ALIGN_DOWN/PTR_IS_ALIGNED macros from Linux to hide the cast.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 include/linux/kernel.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index bf820de22ca7..0e4ba243915b 100644
--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -14,6 +14,8 @@
 #define ALIGN_DOWN(x, a)	ALIGN((x) - ((a) - 1), (a))
 #define __ALIGN_MASK(x, mask)	(((x) + (mask)) & ~(mask))
 #define PTR_ALIGN(p, a)		((typeof(p))ALIGN((unsigned long)(p), (a)))
+#define PTR_ALIGN_DOWN(p, a)	((typeof(p))ALIGN_DOWN((unsigned long)(p), (a)))
+#define PTR_IS_ALIGNED(x, a)	IS_ALIGNED((unsigned long)(x), (a))
 #define IS_ALIGNED(x, a)		(((x) & ((typeof(x))(a) - 1)) == 0)
 
 #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
-- 
2.39.2




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] include: linux/kernel.h: define PTR_ALIGN_DOWN/PTR_IS_ALIGNED
  2023-09-11 10:16 [PATCH] include: linux/kernel.h: define PTR_ALIGN_DOWN/PTR_IS_ALIGNED Ahmad Fatoum
@ 2023-09-12  9:29 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2023-09-12  9:29 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox

On Mon, Sep 11, 2023 at 12:16:33PM +0200, Ahmad Fatoum wrote:
> Pointer casts to integers are a common cause of 64-bit incompatibilities.
> Import PTR_ALIGN_DOWN/PTR_IS_ALIGNED macros from Linux to hide the cast.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  include/linux/kernel.h | 2 ++
>  1 file changed, 2 insertions(+)

Applied, thanks

Sascha

> 
> diff --git a/include/linux/kernel.h b/include/linux/kernel.h
> index bf820de22ca7..0e4ba243915b 100644
> --- a/include/linux/kernel.h
> +++ b/include/linux/kernel.h
> @@ -14,6 +14,8 @@
>  #define ALIGN_DOWN(x, a)	ALIGN((x) - ((a) - 1), (a))
>  #define __ALIGN_MASK(x, mask)	(((x) + (mask)) & ~(mask))
>  #define PTR_ALIGN(p, a)		((typeof(p))ALIGN((unsigned long)(p), (a)))
> +#define PTR_ALIGN_DOWN(p, a)	((typeof(p))ALIGN_DOWN((unsigned long)(p), (a)))
> +#define PTR_IS_ALIGNED(x, a)	IS_ALIGNED((unsigned long)(x), (a))
>  #define IS_ALIGNED(x, a)		(((x) & ((typeof(x))(a) - 1)) == 0)
>  
>  #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
> -- 
> 2.39.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-09-12  9:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-11 10:16 [PATCH] include: linux/kernel.h: define PTR_ALIGN_DOWN/PTR_IS_ALIGNED Ahmad Fatoum
2023-09-12  9:29 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox