From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 12 Sep 2023 13:14:11 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qg1LR-00CZQ1-0T for lore@lore.pengutronix.de; Tue, 12 Sep 2023 13:14:11 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qg1LO-0007sq-Ms for lore@pengutronix.de; Tue, 12 Sep 2023 13:14:11 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GB4u2M41z7q7Zj+x3+YgNHQMyRcEcja3noNmrePJmMs=; b=D8npzIvhBo56Dix6NR0MTB1HIc 5YNln4i57Rr7CFPdp+10oiSh5J2qslQswJ5ZRvxRir4iN5cjy4Gvt9tIezEouNMoRjZ468hOXFd8h k1m7j+Z+JcGxBhfnOe7BXJjMGJ3Di973qD5t5Loi5TIcRY02kWCrlDVLOobG19B9NHESVfUOMz+xn qsagjdhdVmxA3QCMk3jA8Gv6G+SOYJzSORSNfParT79qwk3XsVCD1EEX3Uh0WYnhVoG8E0y66iyis c9x7TyvpTVCTGh5qF3VB/ZcEC3jfYufroSPRzKIwZ0QPvH/kJYKCWJlovX1Y1OFunush0wm2kN6+Y pjfjpqCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qg1KI-003BIx-0L; Tue, 12 Sep 2023 11:13:02 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qg1KF-003BHS-2B for barebox@lists.infradead.org; Tue, 12 Sep 2023 11:13:01 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qg1KE-0007fq-AL; Tue, 12 Sep 2023 13:12:58 +0200 Received: from [2a0a:edc0:2:b01:1d::c0] (helo=ptx.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qg1KD-005lTP-UB; Tue, 12 Sep 2023 13:12:57 +0200 Received: from sha by ptx.whiteo.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1qg1KD-005cbg-Ac; Tue, 12 Sep 2023 13:12:57 +0200 Date: Tue, 12 Sep 2023 13:12:57 +0200 From: Sascha Hauer To: Ahmad Fatoum Cc: barebox@lists.infradead.org Message-ID: <20230912111257.GD637806@pengutronix.de> References: <20230912095809.287289-1-a.fatoum@pengutronix.de> <20230912105658.GC637806@pengutronix.de> <54f9b669-9876-fd86-1ded-99f677e545ad@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54f9b669-9876-fd86-1ded-99f677e545ad@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230912_041259_720989_508E7BD5 X-CRM114-Status: GOOD ( 23.47 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.0 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH] MIPS: bootm: fix format string type mismatch X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On Tue, Sep 12, 2023 at 01:00:22PM +0200, Ahmad Fatoum wrote: > On 12.09.23 12:56, Sascha Hauer wrote: > > On Tue, Sep 12, 2023 at 11:58:09AM +0200, Ahmad Fatoum wrote: > >> While we always have sizeof (struct device_node *) == sizeof(ulong), > >> clangd warns about mixing them as arguments to functions with printf-style > >> format strings. Add a cast to silence the warning. > >> > >> Signed-off-by: Ahmad Fatoum > >> --- > >> arch/mips/lib/bootm.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/arch/mips/lib/bootm.c b/arch/mips/lib/bootm.c > >> index 19d82ec37530..a5bfc6c88c17 100644 > >> --- a/arch/mips/lib/bootm.c > >> +++ b/arch/mips/lib/bootm.c > >> @@ -62,7 +62,7 @@ static int do_bootm_elf(struct image_data *data) > >> } > >> > >> pr_info("Starting application at 0x%08lx, dts 0x%08lx...\n", > >> - data->os_address, data->of_root_node); > >> + data->os_address, (ulong)data->of_root_node); > > > > It's a pointer, so why not print it with 0x%p? > > I have an aversion towards 0x%p, because ISO C leaves it implementation defined > whether %p includes a 0x or not. We have our own %p though, so I don't mind if > you change it while applying. Did that, thanks Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |