mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] fs: fat: enable VFAT long file names by default
Date: Thu, 14 Sep 2023 10:03:27 +0200	[thread overview]
Message-ID: <20230914080327.GM637806@pengutronix.de> (raw)
In-Reply-To: <20230913103552.1644839-1-a.fatoum@pengutronix.de>

On Wed, Sep 13, 2023 at 12:35:52PM +0200, Ahmad Fatoum wrote:
> Apparently, this option defaulted to 'n' since the very beginning, so
> users newly enabling FAT may unwittingly run into a cryptic:
> 
>   barebox@board:/ cp something /mnt/mmc0.0/freertos-main.elf
>   could not open /mnt/mmc0.0/freertos-main.elf: Invalid argument
> 
> As FAT file systems nowadays are VFAT by default and allow up to 255
> characters in file names, there's no reason to restrict barebox to
> classic 8.3 file names by default.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  fs/fat/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/fs/fat/Kconfig b/fs/fat/Kconfig
> index 8cd3b604baeb..53f784ee54d5 100644
> --- a/fs/fat/Kconfig
> +++ b/fs/fat/Kconfig
> @@ -16,7 +16,7 @@ config FS_FAT_WRITE
>  
>  
>  config FS_FAT_LFN
> -	bool
> +	def_bool y
>  	prompt "Support long filenames"
>  	help
>  	  Enable support for file names other than 8.3.
> -- 
> 2.39.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



      reply	other threads:[~2023-09-14  8:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-13 10:35 Ahmad Fatoum
2023-09-14  8:03 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230914080327.GM637806@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox