[PATCH] fs: fat: enable VFAT long file names by default

[PATCH] fs: fat: enable VFAT long file names by default

[Ahmad Fatoum]

Apparently, this option defaulted to 'n' since the very beginning, so
users newly enabling FAT may unwittingly run into a cryptic:

  barebox@board:/ cp something /mnt/mmc0.0/freertos-main.elf
  could not open /mnt/mmc0.0/freertos-main.elf: Invalid argument

As FAT file systems nowadays are VFAT by default and allow up to 255
characters in file names, there's no reason to restrict barebox to
classic 8.3 file names by default.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 fs/fat/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/fat/Kconfig b/fs/fat/Kconfig
index 8cd3b604baeb..53f784ee54d5 100644
--- a/fs/fat/Kconfig
+++ b/fs/fat/Kconfig
@@ -16,7 +16,7 @@ config FS_FAT_WRITE
 
 
 config FS_FAT_LFN
-	bool
+	def_bool y
 	prompt "Support long filenames"
 	help
 	  Enable support for file names other than 8.3.
-- 
2.39.2

Re: [PATCH] fs: fat: enable VFAT long file names by default

[Sascha Hauer]

On Wed, Sep 13, 2023 at 12:35:52PM +0200, Ahmad Fatoum wrote:
> Apparently, this option defaulted to 'n' since the very beginning, so
> users newly enabling FAT may unwittingly run into a cryptic:
> 
>   barebox@board:/ cp something /mnt/mmc0.0/freertos-main.elf
>   could not open /mnt/mmc0.0/freertos-main.elf: Invalid argument
> 
> As FAT file systems nowadays are VFAT by default and allow up to 255
> characters in file names, there's no reason to restrict barebox to
> classic 8.3 file names by default.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  fs/fat/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/fs/fat/Kconfig b/fs/fat/Kconfig
> index 8cd3b604baeb..53f784ee54d5 100644
> --- a/fs/fat/Kconfig
> +++ b/fs/fat/Kconfig
> @@ -16,7 +16,7 @@ config FS_FAT_WRITE
>  
>  
>  config FS_FAT_LFN
> -	bool
> +	def_bool y
>  	prompt "Support long filenames"
>  	help
>  	  Enable support for file names other than 8.3.
> -- 
> 2.39.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |