* [PATCH] globalvar: add a globalvar_get helper
@ 2023-09-21 14:16 Ahmad Fatoum
2023-10-05 6:53 ` Ahmad Fatoum
2023-10-06 11:55 ` Sascha Hauer
0 siblings, 2 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2023-09-21 14:16 UTC (permalink / raw)
To: barebox; +Cc: Ahmad Fatoum
We have functions to set global variables, but none to get them, but
having a globalvar_get helper could be useful to get code size down when
global variables are disabled, as globalvar_get("var") would be optimized
out, while getenv("global.var") wouldn't. Therefore, add the helper.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
include/globalvar.h | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/include/globalvar.h b/include/globalvar.h
index 36a7c7006c76..5fdb70fca911 100644
--- a/include/globalvar.h
+++ b/include/globalvar.h
@@ -10,6 +10,12 @@
extern struct device global_device;
#ifdef CONFIG_GLOBALVAR
+
+static inline const char *globalvar_get(const char *name)
+{
+ return dev_get_param(&global_device, name);
+}
+
int globalvar_add_simple(const char *name, const char *value);
void globalvar_remove(const char *name);
@@ -41,6 +47,11 @@ void dev_param_init_from_nv(struct device *dev, const char *name);
void globalvar_alias_deprecated(const char *newname, const char *oldname);
#else
+static inline const char *globalvar_get(const char *name)
+{
+ return NULL;
+}
+
static inline int globalvar_add_simple(const char *name, const char *value)
{
return 0;
--
2.39.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] globalvar: add a globalvar_get helper
2023-09-21 14:16 [PATCH] globalvar: add a globalvar_get helper Ahmad Fatoum
@ 2023-10-05 6:53 ` Ahmad Fatoum
2023-10-06 11:55 ` Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2023-10-05 6:53 UTC (permalink / raw)
To: Ahmad Fatoum; +Cc: barebox
On 21.09.23 16:16, Ahmad Fatoum wrote:
> We have functions to set global variables, but none to get them, but
> having a globalvar_get helper could be useful to get code size down when
> global variables are disabled, as globalvar_get("var") would be optimized
> out, while getenv("global.var") wouldn't. Therefore, add the helper.
Gentle ping.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> include/globalvar.h | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/include/globalvar.h b/include/globalvar.h
> index 36a7c7006c76..5fdb70fca911 100644
> --- a/include/globalvar.h
> +++ b/include/globalvar.h
> @@ -10,6 +10,12 @@
> extern struct device global_device;
>
> #ifdef CONFIG_GLOBALVAR
> +
> +static inline const char *globalvar_get(const char *name)
> +{
> + return dev_get_param(&global_device, name);
> +}
> +
> int globalvar_add_simple(const char *name, const char *value);
>
> void globalvar_remove(const char *name);
> @@ -41,6 +47,11 @@ void dev_param_init_from_nv(struct device *dev, const char *name);
> void globalvar_alias_deprecated(const char *newname, const char *oldname);
>
> #else
> +static inline const char *globalvar_get(const char *name)
> +{
> + return NULL;
> +}
> +
> static inline int globalvar_add_simple(const char *name, const char *value)
> {
> return 0;
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] globalvar: add a globalvar_get helper
2023-09-21 14:16 [PATCH] globalvar: add a globalvar_get helper Ahmad Fatoum
2023-10-05 6:53 ` Ahmad Fatoum
@ 2023-10-06 11:55 ` Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2023-10-06 11:55 UTC (permalink / raw)
To: Ahmad Fatoum; +Cc: barebox
On Thu, Sep 21, 2023 at 04:16:28PM +0200, Ahmad Fatoum wrote:
> We have functions to set global variables, but none to get them, but
> having a globalvar_get helper could be useful to get code size down when
> global variables are disabled, as globalvar_get("var") would be optimized
> out, while getenv("global.var") wouldn't. Therefore, add the helper.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> include/globalvar.h | 11 +++++++++++
> 1 file changed, 11 insertions(+)
Applied, thanks
Sascha
>
> diff --git a/include/globalvar.h b/include/globalvar.h
> index 36a7c7006c76..5fdb70fca911 100644
> --- a/include/globalvar.h
> +++ b/include/globalvar.h
> @@ -10,6 +10,12 @@
> extern struct device global_device;
>
> #ifdef CONFIG_GLOBALVAR
> +
> +static inline const char *globalvar_get(const char *name)
> +{
> + return dev_get_param(&global_device, name);
> +}
> +
> int globalvar_add_simple(const char *name, const char *value);
>
> void globalvar_remove(const char *name);
> @@ -41,6 +47,11 @@ void dev_param_init_from_nv(struct device *dev, const char *name);
> void globalvar_alias_deprecated(const char *newname, const char *oldname);
>
> #else
> +static inline const char *globalvar_get(const char *name)
> +{
> + return NULL;
> +}
> +
> static inline int globalvar_add_simple(const char *name, const char *value)
> {
> return 0;
> --
> 2.39.2
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-06 11:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-21 14:16 [PATCH] globalvar: add a globalvar_get helper Ahmad Fatoum
2023-10-05 6:53 ` Ahmad Fatoum
2023-10-06 11:55 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox