[PATCH v2 0/2] raspi: pass additional VC values via dtb

[PATCH v2 0/2] raspi: pass additional VC values via dtb

[Denis Osterland-Heim]

v2: fix whitespace error, add acked-by of Ahmad, fix line of 80 chars

Denis OSTERLAND-HEIM (2):
      raspi: support to read vc values via dt-2nd boot
      raspi: fixup additional vc created nodes

 arch/arm/boards/raspberry-pi/rpi-common.c | 69 ++++++++++++++++++++++-
--------
 1 file changed, 49 insertions(+), 20 deletions(-)

Re: [PATCH v2 0/2] raspi: pass additional VC values via dtb

[Sascha Hauer]

Hi Denis,

On Mon, Sep 25, 2023 at 01:09:36PM +0200, Denis Osterland-Heim wrote:
> v2: fix whitespace error, add acked-by of Ahmad, fix line of 80 chars
> 
> Denis OSTERLAND-HEIM (2):
>       raspi: support to read vc values via dt-2nd boot
>       raspi: fixup additional vc created nodes
> 
>  arch/arm/boards/raspberry-pi/rpi-common.c | 69 ++++++++++++++++++++++-
> --------
>  1 file changed, 49 insertions(+), 20 deletions(-)

The patches are still mangled. There are additional linebreaks, spaces
are replaced by UTF-8 character 0xc2a0 and tabs are replaced by multiple
0xc2a0. I fixed this up by hand this time, but please check your setup
for the next time. Are you using git send-email? If not, I'd recommend
doing so.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [PATCH v2 0/2] raspi: pass additional VC values via dtb

[Denis Osterland-Heim]

Hi Sascha,

Thanks for your fixup.
I use git-send-mail with a local transport and evolution to actually
send the mail.
Sounds like a HTML email "optimization".
I will check my setup, maybe I find something in the preference.
There is an option to reencode the mail before send.
Hopefully this prevents gmail from reencode.

I reviewed the patches on next and there is a unintended change in the
pr_err statement, which changes '\n' to 'n'.
In the mail, this is part of the context.

Shall I try to send a fixup?

Regards, Denis

> Hi Denis,
> 
> On Mon, Sep 25, 2023 at 01:09:36PM +0200, Denis Osterland-Heim wrote:
> > v2: fix whitespace error, add acked-by of Ahmad, fix line of 80
> > chars
> > 
> > Denis OSTERLAND-HEIM (2):
> >       raspi: support to read vc values via dt-2nd boot
> >       raspi: fixup additional vc created nodes
> > 
> >  arch/arm/boards/raspberry-pi/rpi-common.c | 69
> > ++++++++++++++++++++++-
> > --------
> >  1 file changed, 49 insertions(+), 20 deletions(-)
> 
> The patches are still mangled. There are additional linebreaks,
> spaces
> are replaced by UTF-8 character 0xc2a0 and tabs are replaced by
> multiple
> 0xc2a0. I fixed this up by hand this time, but please check your
> setup
> for the next time. Are you using git send-email? If not, I'd
> recommend
> doing so.
> 
> Sascha
> 

Re: [PATCH v2 0/2] raspi: pass additional VC values via dtb

[Sascha Hauer]

On Thu, Sep 28, 2023 at 02:57:32PM +0200, Denis Osterland-Heim wrote:
> Hi Sascha,
> 
> Thanks for your fixup.
> I use git-send-mail with a local transport and evolution to actually
> send the mail.
> Sounds like a HTML email "optimization".
> I will check my setup, maybe I find something in the preference.
> There is an option to reencode the mail before send.
> Hopefully this prevents gmail from reencode.
> 
> I reviewed the patches on next and there is a unintended change in the
> pr_err statement, which changes '\n' to 'n'.
> In the mail, this is part of the context.
> 
> Shall I try to send a fixup?

Yes please, seems like a good way to test if your new git-send-mail
setup works ;)

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |