From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 5/5] lib: stackprot: hide symbols when not applicable
Date: Mon, 9 Oct 2023 13:52:39 +0200 [thread overview]
Message-ID: <20231009115239.2291016-5-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20231009115239.2291016-1-a.fatoum@pengutronix.de>
Asking all users about the stacksmash command that's just there to test
stack guard and protector is unnecessary noise. Likewise asking about
PBL stackprotector, when we don't have any.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
commands/Kconfig | 1 +
lib/Kconfig.hardening | 5 +++--
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/commands/Kconfig b/commands/Kconfig
index c1bba22443e6..a6806f198ec4 100644
--- a/commands/Kconfig
+++ b/commands/Kconfig
@@ -2403,6 +2403,7 @@ config CMD_UBSAN
config CMD_STACKSMASH
tristate "stacksmash"
+ depends on STACKPROTECTOR || STACK_GUARD_PAGE || COMPILE_TEST
help
This commands trashes the stack to test stackprotector and
guard page. This command does not return.
diff --git a/lib/Kconfig.hardening b/lib/Kconfig.hardening
index a9d3af110958..f14b256a7d91 100644
--- a/lib/Kconfig.hardening
+++ b/lib/Kconfig.hardening
@@ -61,7 +61,7 @@ config STACKPROTECTOR_ALL
endchoice
choice
- prompt "Stack Protector buffer overflow detection for PBL"
+ prompt "Stack Protector buffer overflow detection for PBL" if PBL_IMAGE
config PBL_STACKPROTECTOR_NONE
bool "None"
@@ -69,6 +69,7 @@ config PBL_STACKPROTECTOR_NONE
config PBL_STACKPROTECTOR_STRONG
bool "Strong"
depends on $(cc-option,-fstack-protector-strong)
+ depends on PBL_IMAGE
select STACKPROTECTOR
help
For PBL, This option turns on the "stack-protector" GCC feature. This
@@ -93,7 +94,7 @@ config PBL_STACKPROTECTOR_STRONG
config PBL_STACKPROTECTOR_ALL
bool "PBL"
depends on $(cc-option,-fstack-protector-strong)
- depends on COMPILE_TEST
+ depends on PBL_IMAGE && COMPILE_TEST
select STACKPROTECTOR
help
This pushes and verifies stack protector canaries on all functions,
--
2.39.2
next prev parent reply other threads:[~2023-10-09 11:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 11:52 [PATCH 1/5] lib: ubsan: disable sanitization for UBSAN implementation Ahmad Fatoum
2023-10-09 11:52 ` [PATCH 2/5] lib: random: don't duplicate error/warning prefix in log message Ahmad Fatoum
2023-10-09 11:52 ` [PATCH 3/5] lib: stackprot: improve error message on missing HWRNG Ahmad Fatoum
2023-10-09 11:52 ` [PATCH 4/5] lib: stackprot: don't directly write stack protector from HWRNG driver Ahmad Fatoum
2023-10-09 11:52 ` Ahmad Fatoum [this message]
2023-10-13 9:17 ` [PATCH 1/5] lib: ubsan: disable sanitization for UBSAN implementation Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231009115239.2291016-5-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox