mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 3/4] test: self: have SELFTEST_ENABLE_ALL select all tests
Date: Mon,  9 Oct 2023 13:52:56 +0200	[thread overview]
Message-ID: <20231009115257.2371076-3-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20231009115257.2371076-1-a.fatoum@pengutronix.de>

CONFIG_SELFTEST_ENABLE_ALL is meant as a toggle to just enable all
tests that are applicable. imply doesn't do what's expected, because
it won't enable an option that's explicitly disabled. Thus switch
over to using select instead and while at it add the missing
select for SELFTEST_TEST_COMMAND.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 test/self/Kconfig | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/test/self/Kconfig b/test/self/Kconfig
index 15e00f0244b5..e7da07491a91 100644
--- a/test/self/Kconfig
+++ b/test/self/Kconfig
@@ -33,16 +33,15 @@ config SELFTEST_ENABLE_ALL
 	select SELFTEST_PROGRESS_NOTIFIER
 	select SELFTEST_OF_MANIPULATION
 	select SELFTEST_ENVIRONMENT_VARIABLES if ENVIRONMENT_VARIABLES
-	imply SELFTEST_FS_RAMFS
-	imply SELFTEST_TFTP
-	imply SELFTEST_JSON
-	imply SELFTEST_DIGEST
-	imply SELFTEST_MMU
-	imply SELFTEST_STRING
-	imply SELFTEST_SETJMP
-	imply SELFTEST_REGULATOR
-	help
-	  Selects all self-tests compatible with current configuration
+	select SELFTEST_FS_RAMFS if FS_RAMFS
+	select SELFTEST_TFTP if FS_TFTP
+	select SELFTEST_JSON if JSMN
+	select SELFTEST_DIGEST if DIGEST
+	select SELFTEST_MMU if MMU
+	select SELFTEST_STRING
+	select SELFTEST_SETJMP if ARCH_HAS_SJLJ
+	select SELFTEST_REGULATOR if REGULATOR && OFDEVICE
+	select SELFTEST_TEST_COMMAND if CMD_TEST
 
 config SELFTEST_MALLOC
 	bool "malloc() selftest"
-- 
2.39.2




  parent reply	other threads:[~2023-10-09 11:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-09 11:52 [PATCH 1/4] test: self: mmu: use constants for the hardcoded buffer sizes Ahmad Fatoum
2023-10-09 11:52 ` [PATCH 2/4] test: self: mmu: reduce MMU test region size Ahmad Fatoum
2023-10-09 11:52 ` Ahmad Fatoum [this message]
2023-10-09 11:52 ` [PATCH 4/4] test: self: warn and exit if device tree parsing fails Ahmad Fatoum
2023-10-13  9:19 ` [PATCH 1/4] test: self: mmu: use constants for the hardcoded buffer sizes Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231009115257.2371076-3-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox