mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH] uncompress: make use of error_fn in uncompress_buf_to_buf
Date: Mon,  9 Oct 2023 13:53:10 +0200	[thread overview]
Message-ID: <20231009115310.2398292-1-a.fatoum@pengutronix.de> (raw)

uncompress_buf_to_buf already accepts an error_fn, but didn't make use
of it and instead relied on the default uncompress_err_stdout.

Fix this. The user-visible effect of this is that failure to decompress
FIT image contents is now printed with pr_err instead of the default
printf. No other upstream users of uncompress_buf_to_buf currently exist.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 lib/uncompress.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/uncompress.c b/lib/uncompress.c
index 0608e9f9d30f..71ac882b87fe 100644
--- a/lib/uncompress.c
+++ b/lib/uncompress.c
@@ -199,7 +199,7 @@ ssize_t uncompress_buf_to_buf(const void *input, size_t input_len,
 		goto free_temp;
 	}
 
-	ret = uncompress_buf_to_fd(input, input_len, outfd, uncompress_err_stdout);
+	ret = uncompress_buf_to_fd(input, input_len, outfd, error_fn);
 	if (ret)
 		goto close_outfd;
 
-- 
2.39.2




             reply	other threads:[~2023-10-09 11:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-09 11:53 Ahmad Fatoum [this message]
2023-10-10 14:36 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231009115310.2398292-1-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox