[PATCH] uncompress: make use of error_fn in uncompress_buf_to_buf

[PATCH] uncompress: make use of error_fn in uncompress_buf_to_buf

[Ahmad Fatoum]

uncompress_buf_to_buf already accepts an error_fn, but didn't make use
of it and instead relied on the default uncompress_err_stdout.

Fix this. The user-visible effect of this is that failure to decompress
FIT image contents is now printed with pr_err instead of the default
printf. No other upstream users of uncompress_buf_to_buf currently exist.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 lib/uncompress.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/uncompress.c b/lib/uncompress.c
index 0608e9f9d30f..71ac882b87fe 100644
--- a/lib/uncompress.c
+++ b/lib/uncompress.c
@@ -199,7 +199,7 @@ ssize_t uncompress_buf_to_buf(const void *input, size_t input_len,
 		goto free_temp;
 	}
 
-	ret = uncompress_buf_to_fd(input, input_len, outfd, uncompress_err_stdout);
+	ret = uncompress_buf_to_fd(input, input_len, outfd, error_fn);
 	if (ret)
 		goto close_outfd;
 
-- 
2.39.2

Re: [PATCH] uncompress: make use of error_fn in uncompress_buf_to_buf

[Sascha Hauer]

On Mon, Oct 09, 2023 at 01:53:10PM +0200, Ahmad Fatoum wrote:
> uncompress_buf_to_buf already accepts an error_fn, but didn't make use
> of it and instead relied on the default uncompress_err_stdout.
> 
> Fix this. The user-visible effect of this is that failure to decompress
> FIT image contents is now printed with pr_err instead of the default
> printf. No other upstream users of uncompress_buf_to_buf currently exist.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  lib/uncompress.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/lib/uncompress.c b/lib/uncompress.c
> index 0608e9f9d30f..71ac882b87fe 100644
> --- a/lib/uncompress.c
> +++ b/lib/uncompress.c
> @@ -199,7 +199,7 @@ ssize_t uncompress_buf_to_buf(const void *input, size_t input_len,
>  		goto free_temp;
>  	}
>  
> -	ret = uncompress_buf_to_fd(input, input_len, outfd, uncompress_err_stdout);
> +	ret = uncompress_buf_to_fd(input, input_len, outfd, error_fn);
>  	if (ret)
>  		goto close_outfd;
>  
> -- 
> 2.39.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |