From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH] commands: keystore: work around missing initialization false positive
Date: Mon, 9 Oct 2023 13:53:16 +0200 [thread overview]
Message-ID: <20231009115316.2418494-1-a.fatoum@pengutronix.de> (raw)
clang is unhappy about this. While I can't see how s_len could be used
uninitialized, there's value in silencing these warnings, so the real
issues are not as easy to overlook.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
commands/keystore.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/commands/keystore.c b/commands/keystore.c
index 4922cf1bebe9..40bcb7105d75 100644
--- a/commands/keystore.c
+++ b/commands/keystore.c
@@ -17,7 +17,7 @@ static int do_keystore(int argc, char *argv[])
const char *file = NULL;
char *secret_str = NULL;
void *secret;
- size_t s_len;
+ size_t s_len = 0;
while ((opt = getopt(argc, argv, "rs:f:")) > 0) {
switch (opt) {
--
2.39.2
next reply other threads:[~2023-10-09 11:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 11:53 Ahmad Fatoum [this message]
2023-10-10 14:33 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231009115316.2418494-1-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox