From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 20 Oct 2023 15:05:00 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qtpBV-00FZFf-5f for lore@lore.pengutronix.de; Fri, 20 Oct 2023 15:05:00 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qtpBT-0006v3-B0 for lore@pengutronix.de; Fri, 20 Oct 2023 15:04:59 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YYo7GMjP80PGp1gpuJT6FOF4I4LrYoo8CXckgM0Ziys=; b=CNagxgLlTGEszeOn3y23OFI8+4 JMmacoRw+atF1ZNn2+7Hss00pmS2joWxdXdGHFu3yHEzTsE6TBHx7ejCmY8JyHX6+wJc0rVr97mIp /xEdcqRH8mdOtNgTvMrsS64vnD1DEMbP3LAsHwqhcTQ91g1hkUrnENo6B65deh7zifk1bdsZ2f5c+ vH3DLyVCFGBpGkXq+pzYoHi98cNUDNXenGPPNYhW0EkoRHS2f+HrIeyMHw1vSYjOJnQUhgzDYK07K DuXpQua+DDIcwZFQG4ZcH7PYIrBIQtOHvCvvJIlszU4qnqaw+D0lSsxeye8HeNSm+XIiz/ixhPQCr EkOafunw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qtpAG-002JMA-2K; Fri, 20 Oct 2023 13:03:44 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qtpAD-002JLb-12 for barebox@lists.infradead.org; Fri, 20 Oct 2023 13:03:42 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qtpA7-0006hq-Jo; Fri, 20 Oct 2023 15:03:35 +0200 Received: from [2a0a:edc0:2:b01:1d::c0] (helo=ptx.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qtpA7-0031yw-7P; Fri, 20 Oct 2023 15:03:35 +0200 Received: from mfe by ptx.whiteo.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1qtpA7-00FRsA-59; Fri, 20 Oct 2023 15:03:35 +0200 Date: Fri, 20 Oct 2023 15:03:35 +0200 From: Marco Felsch To: Ahmad Fatoum Cc: barebox@lists.infradead.org Message-ID: <20231020130335.dm7qipxvsbf7375w@pengutronix.de> References: <20231020121710.658511-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231020121710.658511-1-a.fatoum@pengutronix.de> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231020_060341_374161_757F50EA X-CRM114-Status: GOOD ( 15.81 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.9 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH] ARM: i.MX8M: limit PBL size to 0x3f000 X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On 23-10-20, Ahmad Fatoum wrote: > On i.MX8M(Q/M/N/P), barebox PBL is loaded 0x1000 bytes into ITCM Nit: only the i.MX8MQ-EVK was converted. Don't know if the rest is broken since they don't use the pblb (PBL only). > at address 0x7e00_1000. ITCM is 128K followed by 128K of DTCM. > > Therefore, in total, barebox PBL may not exceed 0x3f000. Now that we > have a common macro for defining boards, let's add a > MAX_PBL_MEMORY_SIZE_$(entrypoint) into it, so check that we don't > exceed this size at runtime. > > Boards that trip over this, should consider using get_builtin_firmware_ext > to offload binaries into barebox proper. > > Signed-off-by: Ahmad Fatoum Reviewed-by: Marco Felsch > --- > images/Makefile.imx | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/images/Makefile.imx b/images/Makefile.imx > index 50f0a64b3091..ca09853c4b6e 100644 > --- a/images/Makefile.imx > +++ b/images/Makefile.imx > @@ -26,6 +26,7 @@ $(eval > ifeq ($($(strip $(1))), y) > pblb-y += $(strip $(2)) > CFG_$(strip $(2)).pblb.imximg = $(board)/$(strip $(3)).imxcfg > + MAX_PBL_MEMORY_SIZE_$(strip $(2)) = 0x3f000 > FILE_barebox-$(strip $(4)).img = $(strip $(2)).pblb.pimximg > FILE_barebox-$(strip $(4))-s.img = $(strip $(2)).pblb.psimximg > image-y += barebox-$(strip $(4)).img > -- > 2.39.2 > > >