Re: [PATCH 2/2] scripts: get_maintainers: drop --status enforcement

[Marco Felsch <m.felsch@pengutronix.de>]

On 23-10-26, Ahmad Fatoum wrote:
> On 26.10.23 16:27, Marco Felsch wrote:
> > On 23-10-26, Ahmad Fatoum wrote:
> >> On 26.10.23 14:46, Marco Felsch wrote:
> >>> The status parameter is never used so drop it and stop bother the user
> >>> of the script.
> >>>
> >>> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> >>
> >> Our get_maintainer.pl script doesn't have the same breadth of features
> >> as the kernel's and only --status is implemented, thus the check.
> > 
> > Where? I see only 'print << 'EOT' <text> EOT'
> 
> Ye, the output is similar to what you'd get with the kernel's --status.
> The script is just here, because checkpatch depends on it and calls
> it with --status.

You still can run it with --status, I just won't enforce it. At least to
me it's not clear why we need to enforce it and I use the script from
time to time and always forget the param.

Regards,
  Marco

> 
> Cheers,
> Ahmad
> 
> > 
> > Regards,
> >   Marco
> > 
> >>
> >>> ---
> >>>  scripts/get_maintainer.pl | 2 --
> >>>  1 file changed, 2 deletions(-)
> >>>
> >>> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> >>> index 7c0d50333400..a19c0e7305d0 100755
> >>> --- a/scripts/get_maintainer.pl
> >>> +++ b/scripts/get_maintainer.pl
> >>> @@ -2,8 +2,6 @@
> >>>  # SPDX-License-Identifier: GPL-2.0-only
> >>>  # Dummy get_maintainer.pl script for checkpatch.pl to use
> >>>  
> >>> -die "USAGE: get_maintainer.pl --status\n" unless grep /--status/, @ARGV;
> >>> -
> >>>  print <<'EOT'
> >>>  Sascha Hauer <s.hauer@pengutronix.de> (maintainer:BAREBOX)
> >>>  barebox@lists.infradead.org (open list:BAREBOX)
> >>
> >> -- 
> >> Pengutronix e.K.                           |                             |
> >> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> >> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> >> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> >>
> >>
> > 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
>