From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 26 Oct 2023 16:44:34 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qw1b8-004eLo-Vm for lore@lore.pengutronix.de; Thu, 26 Oct 2023 16:44:34 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qw1b7-0004pF-Op for lore@pengutronix.de; Thu, 26 Oct 2023 16:44:34 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:To:From:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=gsOI0uW5+KJw63edRBVxv36Au1xGFyfUcXRkfr7B4AA=; b=fa1rf19zsCDz8+0D0+F1gmXnPB 7bVQJN0EXgFr72rCtuYaurNMQnQOoJ5Ikvne/0iSDY0Qw7mwwt2kxeidoZ/Tp8v8iaILg94CA1+9D k6FyVHkzNBada3E93Fcru9koCrPVnsnSJpzOZyBdk90MwjVLAJ/TQRHB6974Ra8k4MI1YMTTdNnDP RDAOpEISJ7rq29b2Ze/q36RTxDu7tKa0YkxyVIaS5D+ejGFEBUt/smK2AuWarSZwDDI4O77pEfUi4 1Dtmw3zl5+F+u2BK4E4nknKcMCyWLZ5ofnXQs1zamBlQVXiJnTbZErKfQgacRwqpsM89LElvoAH6d 9pTQV0lA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qw1a7-00Eixc-0j; Thu, 26 Oct 2023 14:43:31 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qw1a4-00Eiwn-0i for barebox@lists.infradead.org; Thu, 26 Oct 2023 14:43:29 +0000 Received: from dude02.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::28]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qw1a2-0004cg-U7 for barebox@lists.infradead.org; Thu, 26 Oct 2023 16:43:26 +0200 From: Marco Felsch To: barebox@lists.infradead.org Date: Thu, 26 Oct 2023 16:43:24 +0200 Message-Id: <20231026144325.4172966-1-m.felsch@pengutronix.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231026_074328_255307_1A6F84B7 X-CRM114-Status: UNSURE ( 8.82 ) X-CRM114-Notice: Please train this message. X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.9 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH v2 1/2] usb: gadget: initialize serialnumber X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) Windows hosts do require the serial number to be set to any ascii string to enumerate correctly. Set the serial number if provided or to "unset" if not to provide a sane default which works for both hosts. Reported-by: Andrey Zhizhikin Signed-off-by: Marco Felsch --- Changelog v2: - adapt commit message - use barebox_get_serial_number() and "unset" drivers/usb/gadget/udc/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c index b58498680ad1..e7cfa0d5d836 100644 --- a/drivers/usb/gadget/udc/core.c +++ b/drivers/usb/gadget/udc/core.c @@ -1204,7 +1204,7 @@ int usb_add_gadget(struct usb_gadget *gadget) gadget->productname = xstrdup(barebox_get_model()); dev_add_param_string(&gadget->dev, "productname", NULL, NULL, &gadget->productname, NULL); - gadget->serialnumber = xstrdup(""); + gadget->serialnumber = xstrdup(barebox_get_serial_number() ? : "unset"); dev_add_param_string(&gadget->dev, "serialnumber", NULL, NULL, &gadget->serialnumber, NULL); -- 2.39.2