From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH] ARM: stm32mp: define stm32_serial_putc for use with pbl_set_putc
Date: Wed, 1 Nov 2023 13:07:38 +0100 [thread overview]
Message-ID: <20231101120738.3766156-1-a.fatoum@pengutronix.de> (raw)
Unlike other debug_ll headers, such as i.MX's or AT91, the STM32MP1 header
only defined PUTC_LL, but no function suitable for use with
pbl_set_putc.
Remedy that, so PBL entry points can benefit from CONFIG_PBL_CONSOLE and
while at it, add the missing header that defines BIT().
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
include/mach/stm32mp/debug_ll.h | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/include/mach/stm32mp/debug_ll.h b/include/mach/stm32mp/debug_ll.h
index 03bb60a239c1..0d88910c1375 100644
--- a/include/mach/stm32mp/debug_ll.h
+++ b/include/mach/stm32mp/debug_ll.h
@@ -5,6 +5,7 @@
#include <io.h>
#include <mach/stm32mp/stm32.h>
+#include <linux/bitops.h>
#define DEBUG_LL_UART_ADDR STM32_UART4_BASE
@@ -18,13 +19,18 @@
#define USART_ISR_TXE BIT(7)
-static inline void PUTC_LL(int c)
+static inline void stm32_serial_putc(void *ctx, int c)
{
- void __iomem *base = IOMEM(DEBUG_LL_UART_ADDR);
+ void __iomem *base = IOMEM(ctx);
writel(c, base + TDR_OFFSET);
while ((readl(base + ISR_OFFSET) & USART_ISR_TXE) == 0);
}
+static inline void PUTC_LL(int c)
+{
+ stm32_serial_putc(IOMEM(DEBUG_LL_UART_ADDR), c);
+}
+
#endif /* __MACH_STM32MP1_DEBUG_LL_H */
--
2.39.2
next reply other threads:[~2023-11-01 12:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 12:07 Ahmad Fatoum [this message]
2023-11-03 7:37 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231101120738.3766156-1-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox