From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 09 Nov 2023 13:11:28 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1r13se-004A3l-0O for lore@lore.pengutronix.de; Thu, 09 Nov 2023 13:11:28 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r13se-0008Hf-4i for lore@pengutronix.de; Thu, 09 Nov 2023 13:11:28 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=KTnrhH38jvYcRJPtaAxFmfd0SVui8D5oK6PSQcd5mQ8=; b=l5ceAALOb95DWnOEr4znbtA+u/ Jr+f1xgDp1weFUVjHnlnCTmKx9TKo+26iuUw5PS1NblAyf1IXhQ9nxR3kj9pPWzjvOIor+e0lyAP+ kMwZjeXE/aV6NjJtIuB5zL9SF5SPninF26V41x2Zv5QvGR2gmXG+S/pYK5pxEXsjI8tPk4Kz0extb SN4Jc3RbtpaUHFM5a0UeV88Kh8mChYc8UVx/ZDfET5e5VRYW9CuGwamoDLgcDQTe0aPNaFTuPUnsq PO48dwhtr6ZYQAYMWiADz8mopgWE7PtUuKnqAcUmOzoXeYHDkwT2EjMIHmLpz/Qm7o4mcqHwifZiI y9PYJVgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r13rX-006I7x-1A; Thu, 09 Nov 2023 12:10:19 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r13rT-006I7c-2T for barebox@lists.infradead.org; Thu, 09 Nov 2023 12:10:16 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r13rS-00081X-8Z; Thu, 09 Nov 2023 13:10:14 +0100 Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r13rR-007liD-SF; Thu, 09 Nov 2023 13:10:13 +0100 Received: from localhost ([::1] helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1r13rR-006BbB-2W; Thu, 09 Nov 2023 13:10:13 +0100 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum Date: Thu, 9 Nov 2023 13:10:12 +0100 Message-Id: <20231109121012.1474536-1-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231109_041015_826191_9BC1FDA8 X-CRM114-Status: GOOD ( 14.51 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.9 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH master] phy: stm32-usbphyc: fix unbalanced phy exit X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On the STM32MP1, shutting down barebox can result in a ERROR: phy1: phy exit failed --> -22 message printed to the console. This is because the regulator is disabled more often than it was enabled, because stm32_usbphyc_pll_disable is called twice: - Once from stm32_usbphyc_remove calling stm32_usbphyc_phy_exit - Once from dwc2_remove calling phy_exit -> stm32_usbphyc_phy_exit The code is taken from Linux and likely causes no issues there, because devices are removed in reverse probe order, which barebox doesn't enforce. Properly solving this would be a larger endeavour, so for now just fix the stm32-usbphyc driver to ignore reference count dropping below zero and only call __stm32_usbphyc_pll_disable once. Signed-off-by: Ahmad Fatoum --- drivers/phy/phy-stm32-usbphyc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/phy-stm32-usbphyc.c b/drivers/phy/phy-stm32-usbphyc.c index ac82b019f44c..91f4e7f7e08d 100644 --- a/drivers/phy/phy-stm32-usbphyc.c +++ b/drivers/phy/phy-stm32-usbphyc.c @@ -277,7 +277,7 @@ static int __stm32_usbphyc_pll_disable(struct stm32_usbphyc *usbphyc) static int stm32_usbphyc_pll_disable(struct stm32_usbphyc *usbphyc) { /* Check if a phy port is still active or clk48 in use */ - if (atomic_dec_return(&usbphyc->n_pll_cons) > 0) + if (atomic_dec_return(&usbphyc->n_pll_cons) != 1) return 0; return __stm32_usbphyc_pll_disable(usbphyc); -- 2.39.2